Cleanup CXFile support and add unique_id #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As this PR introduces breaking changes, we should add a guidance somewhere to let users know how to upgrade. Another way is to rename |
|
Thinking it through, I think it is cleaner to wrap CXFile in a CLFile, and to not make breaking changes. I will update the PR |
habemus-papadum
force-pushed
the
np/file
branch
2 times, most recently
from
9b12cfc
to
def9654
Compare
|
This should be added in v0.18. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is somewhat invasive, but hopefully not too scary.
It will help for adding support for modules which are uniqued by their ast file. I included the commit from #423 which is pretty simple. I can close that PR if you take this onn or I can rebase this one later.