Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an exclusivity list to output options #360

Merged
merged 2 commits into from
Dec 25, 2021

Conversation

KristofferC
Copy link
Contributor

If this list is given, only symbols in the list will be output.

If this is deemed an ok idea, I can add tests etc.

symbols only in this list will be ouput
@Gnimuc
Copy link
Member

Gnimuc commented Dec 20, 2021

This seems to be the first step to #344

@KristofferC
Copy link
Contributor Author

So this should also get everything dependent on the symbols in the exclusive list?

@Gnimuc
Copy link
Member

Gnimuc commented Dec 21, 2021

If this list is given, only symbols in the list will be output.

If a symbol in this list depends on other symbols that are not in this list, then the generated Julia code can not be run.

What #344 described is that we let Clang.jl automatically creates a minimal symbol set from this list to make sure the generated code is runnable.

@@ -58,6 +58,9 @@ output_ignorelist = [
"LLVM_CLANG_C_EXTERN_C_END"
]

# Only output id in the `output_exclusivelist"
# output_output_exclusivelist = []

Copy link
Member

@Gnimuc Gnimuc Dec 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge this and keep this feature private for now.

@Gnimuc Gnimuc merged commit 86f9a34 into JuliaInterop:master Dec 25, 2021
@KristofferC KristofferC deleted the kc/excl branch December 25, 2021 15:35
@KristofferC
Copy link
Contributor Author

Thanks! I have use for this in a wrapper I am toying with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants