README: build requirements, -lpthreads fix #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keno
added a commit
that referenced
this pull request
Dec 9, 2014
README: build requirements, -lpthreads fix
| ```sh | ||
| USE_SYSTEM_LIBM=1 | ||
| LLDB_VER=master |
There was a problem hiding this comment.
Does this need to be prefixed with 'override'?
|
I also had to change the line with |
|
Sounds like another PR is in order; better to edit the README directly than to comment here, since this is already merged. |
sjkelly
added a commit
to sjkelly/Cxx.jl
that referenced
this pull request
Dec 17, 2014
Based on comments in JuliaInterop#38
Merged
|
Sounds good. I just wanted to make sure the changes seemed legitimate. Updated in #42 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #27 (comment)