Minor NSArray improvements #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #26 +/- ##
==========================================
+ Coverage 69.48% 69.68% +0.19%
==========================================
Files 9 9
Lines 626 630 +4
==========================================
+ Hits 435 439 +4
Misses 191 191 ☔ View full report in Codecov by Sentry. |
|
Test failures unrelated; looks like the dispatch tests are a little fragile. |
vtjnash
reviewed
Feb 14, 2024
Comment on lines
+298
to
+301
| # XXX: it's too bad `cconvert` cannot do the `[pointer(obj) for obj in objs]` for us | ||
| # (because we can only derive unsafe references in `unsafe_convert`) | ||
| Base.unsafe_convert(T::Type{<:id}, ptrs::Vector{<:id}) = | ||
| reinterpret(T, pointer(ptrs)) |
There was a problem hiding this comment.
FWIW, this is what Base.RefArray is for doing, as it will recursively derive a pointer for you after cconverting recursively
There was a problem hiding this comment.
Ah, interesting, I figured something like that would exist already.
I think I'll have to copy the pattern though, as AFAIU RefArray only works to ultimately convert to a Ptr, while we're using a custom id pointer here.
EDIT: #27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25
This prevents constructing invalid NSArray objects (and likely segfaulting) by both constraining the type signature, and by not using the questionable
Ptr{id{Object}}type signature (idis already a pointer, and relying on Julia'sPtrleads to surprising automatic conversion from otherwise incompatible array values).