Fixed the breaks by New version of ModelingToolkit #139

yashvardhan747 · 2019-05-04T03:53:22Z

Solves Issue #138

yashvardhan747 · 2019-05-11T16:33:57Z

JuliaRegistrator · 2019-05-11T16:33:58Z

Error while trying to register: Register Failed
@Yashcodes, it looks like you are not a publicly listed member/owner in the parent organization (JuliaIntervals).
If you are a member/owner, you will need to change your membership to public. See GitHub Help

yashvardhan747 · 2019-05-11T16:34:23Z

@JuliaRegistrator register()

JuliaRegistrator · 2019-05-11T16:34:24Z

Error while trying to register: Register Failed
@Yashcodes, it looks like you are not a publicly listed member/owner in the parent organization (JuliaIntervals).
If you are a member/owner, you will need to change your membership to public. See GitHub Help

mforets · 2019-05-11T16:37:30Z

docs/src/index.md

+  - variables: Symbol[:x, :y, :z]
+  - expression: y() + z()
+```
+We can make object (of type `Separator` or `Contractor`)by just using function name (Note: you have to specify variables explicitly as discussed above when you make objects by using function name). We can also use polynomial function to make objects.


Suggested change

We can make object (of type `Separator` or `Contractor`)by just using function name (Note: you have to specify variables explicitly as discussed above when you make objects by using function name). We can also use polynomial function to make objects.

We can make objects (of type `Separator` or `Contractor`) by just using the function name (Note: you have to specify variables explicitly as discussed above in this case). We can also use a polynomial function as shown below.

mforets · 2019-05-11T16:41:47Z

docs/src/index.md

+  - expression: x() + y() == [-∞, 1]
+```
+#### BasicContractor
+Object of type `Contractor` have four feilds (variables, forward, backward and expression), among them data of two feilds (forward, backward) are useful (i.e forward and backward functions) for further usage of that object, thats why it is preferred to use an object of type `BasicContractor` in place of `Contractor` which only contain these two feilds for less usage of memory by unloading all the extra stuff.(Note: Like object of `Contractor` type,`BasicContractor`'s object will also have all the properties which are discussed above).


Suggested change

Object of type `Contractor` have four feilds (variables, forward, backward and expression), among them data of two feilds (forward, backward) are useful (i.e forward and backward functions) for further usage of that object, thats why it is preferred to use an object of type `BasicContractor` in place of `Contractor` which only contain these two feilds for less usage of memory by unloading all the extra stuff.(Note: Like object of `Contractor` type,`BasicContractor`'s object will also have all the properties which are discussed above).

Objects of type `Contractor` have four fields (variables, forward, backward and expression), among them data of two fields (forward, backward) are useful (i.e. forward and backward functions) for further usage of that object, that's why it is preferred to use an object of type `BasicContractor` in place of `Contractor` which only contain these two fields for less usage of memory by unloading all the extra stuff. (Note: Like object of `Contractor` type,`BasicContractor`'s object will also have all the properties which are discussed above).

That's a very silly mistake, thanks for pointing it out.

thats why it is preferred to use an object of type BasicContractor in place of Contractor

In which context is it preferred? Like, from the user perspective, for library code? I think that dwelling a bit into some of these details, or giving another example, would improve that paragraph.

Also i guess that the other two fields of Contractor do have a reason to exist and they are "useful" in some sense (at least internally). I think that this sentence could be improved a bit: "... only contain these two fields for less usage of memory by unloading all the extra stuff..".

Nice work!

As I already mentioned in the paragraph, using BasicContractor is better because of less usage of memory and for less time complexity.
Other two fields are their just to give information about variables and expression used, which has no usage in contracting the interval w.r.t given constraint for which the object is used which is done by just using forward and backward function. Yes, Internally information about variables and expression is necessary after all only they are used to make forward and backward function but finally we just need these two functions. And these forward and backward functions are present in object .of type BasicContractor.

dpsanders · 2019-05-12T00:02:40Z

test/runtests.jl

@@ -59,10 +59,10 @@ end
    C2 = Contractor(vars, y+z)
    @test C2(A,X) == IntervalBox(0.5..1.5, 0.5..0.5, 0.5..0.5)

-    C1 = Contractor([:x,:y,:z], x+y)
+    C1 = Contractor([x,y,z], x+y)


Add spaces: [x, y, z].

dpsanders · 2019-05-12T00:03:32Z

test/runtests.jl

    @test C1(A,X) == IntervalBox(0.5..0.5, 0.5..0.5, 0.5..1.5)

-    C2 = Contractor([:x,:y,:z], y+z)
+    C2 = Contractor([x,y,z], y+z)
    @test C2(A,X) == IntervalBox(0.5..1.5, 0.5..0.5, 0.5..0.5)


You need to make this result be different from the previous one in order to check that x + y and y + z actually give different results.

It is already shown that results are different for x+y and y+z.

C1(A,X) and C2(A,X) are giving different results

You're right, sorry -- my mistake.

dpsanders · 2019-05-12T05:36:49Z

You seem to have added extra docs files in the latest commit that I don't think should be there?

yashvardhan747 · 2019-05-12T06:59:05Z

@JuliaRegistrator register()

JuliaRegistrator · 2019-05-12T06:59:06Z

Error while trying to register: Register Failed
@Yashcodes, it looks like you are not a publicly listed member/owner in the parent organization (JuliaIntervals).
If you are a member/owner, you will need to change your membership to public. See GitHub Help

dpsanders · 2019-05-12T09:33:20Z

Project.toml

@@ -0,0 +1,25 @@
+name = "IntervalConstraintProgramming"
+uuid = "138f1668-1576-5ad7-91b9-7425abbf3153"
+version = "0.1.1"


0.11, not 0.1.1

dpsanders · 2019-05-12T09:34:40Z

docs/build/assets/arrow.svg

@@ -0,0 +1,63 @@
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>


These are files that are generated in the build process and should not be included.

Ohh. I'll delete them

dpsanders · 2019-05-12T09:35:05Z

docs/src/index.md

@@ -59,6 +59,95 @@ julia> outer
 ([-100, 100],[-100, 100])
 ```

+### Without using Macros


dpsanders · 2019-05-16T05:04:41Z

Project.toml

+IntervalContractors = "≥ 0.3.0"
+IntervalRootFinding = "≥ 0.4.0"
+MacroTools = "≥ 0.4.0"
+julia = "≥ 1.0.0"


Aren't we requiring Julia 1.1? And ModelingToolkit 0.2

Oh Right, Sorry its by mistake.
But Isn't for ModelingToolkit it should be autogenerated ?

I guess it's because you hadn't put a lower bound in to REQUIRE.
Just add it by hand.

dpsanders · 2019-05-17T03:51:45Z

Did you see my comment about Project.toml and the versions we require?

yashvardhan747 · 2019-05-17T06:51:01Z

Did you see my comment about Project.toml and the versions we require?

Yes I did

dpsanders · 2019-05-18T06:02:04Z

Thanks!

yashvardhan747 changed the title ~~fixed_the_breaks_for_new_version_of_ModelingToolkit~~ Fixed the breaks by New version of ModelingToolkit May 4, 2019

yashcodes added 2 commits May 4, 2019 09:24

fixed_the_breaks_for_new_version_of_ModelingToolkit

47db901

Doc updated

d357bec

mforets reviewed May 11, 2019

View reviewed changes

Update docs deployment

ac3197d

dpsanders reviewed May 12, 2019

View reviewed changes

yashcodes added 3 commits May 12, 2019 07:50

fixed .travis.yml and appevyor.yml

ce5530b

fixed .travis.yml and appevyor.yml

4d0cb10

fixed .travis.yml

f6c0d2c

docs/Project.toml edited

dd539a5

dpsanders reviewed May 12, 2019

View reviewed changes

Removal of unwanted files

0696597

dpsanders reviewed May 16, 2019

View reviewed changes

yashcodes added 2 commits May 17, 2019 16:58

Few correction in Project.toml

7dc01d0

Mistakes corrected in Project.toml

4a08be5

dpsanders merged commit c60a5df into JuliaIntervals:master May 18, 2019

dpsanders mentioned this pull request May 22, 2019

Breaks with new version of ModelingToolkit #138

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed the breaks by New version of ModelingToolkit #139

Fixed the breaks by New version of ModelingToolkit #139

yashvardhan747 commented May 4, 2019 •

edited

Loading

yashvardhan747 commented May 11, 2019

JuliaRegistrator commented May 11, 2019

yashvardhan747 commented May 11, 2019

JuliaRegistrator commented May 11, 2019

mforets May 11, 2019 •

edited

Loading

mforets May 11, 2019

yashvardhan747 May 11, 2019

mforets May 11, 2019

yashvardhan747 May 11, 2019

dpsanders May 12, 2019

dpsanders May 12, 2019

yashvardhan747 May 12, 2019

yashvardhan747 May 12, 2019

dpsanders May 12, 2019

dpsanders commented May 12, 2019

yashvardhan747 commented May 12, 2019

JuliaRegistrator commented May 12, 2019

dpsanders May 12, 2019

dpsanders May 12, 2019

yashvardhan747 May 14, 2019

dpsanders May 12, 2019

yashvardhan747 May 14, 2019

dpsanders May 16, 2019

yashvardhan747 May 17, 2019

dpsanders May 17, 2019

dpsanders commented May 17, 2019

yashvardhan747 commented May 17, 2019

dpsanders commented May 18, 2019

	We can make object (of type `Separator` or `Contractor`)by just using function name (Note: you have to specify variables explicitly as discussed above when you make objects by using function name). We can also use polynomial function to make objects.
	We can make objects (of type `Separator` or `Contractor`) by just using the function name (Note: you have to specify variables explicitly as discussed above in this case). We can also use a polynomial function as shown below.

		@@ -0,0 +1,63 @@
		<?xml version="1.0" encoding="UTF-8" standalone="no"?>

Fixed the breaks by New version of ModelingToolkit #139

Fixed the breaks by New version of ModelingToolkit #139

Conversation

yashvardhan747 commented May 4, 2019 • edited Loading

yashvardhan747 commented May 11, 2019

JuliaRegistrator commented May 11, 2019

yashvardhan747 commented May 11, 2019

JuliaRegistrator commented May 11, 2019

mforets May 11, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dpsanders commented May 12, 2019

yashvardhan747 commented May 12, 2019

JuliaRegistrator commented May 12, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dpsanders commented May 17, 2019

yashvardhan747 commented May 17, 2019

dpsanders commented May 18, 2019

yashvardhan747 commented May 4, 2019 •

edited

Loading

mforets May 11, 2019 •

edited

Loading