-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#92 - Generalize input of validated integ #103
Conversation
Pull Request Test Coverage Report for Build 661552514Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
I've updated the title of the PR because the branch is still WIP: some additional arguments need to be passed to the initialization functions (eg. |
This is now ready for review. Tests pass locally (julia v1.5.2). |
Thanks a lot for addressing #92! LGTM. Could you perhaps add some tests for the new method? (Maybe simply adapt the existing ones?) |
this could be defined in IntervalArithmetic.jl (see JuliaIntervals/IntervalArithmetic.jl#446) |
Should we merge this? Or you'd like to add some further tests? |
I would prefer to have some tests... it always helps! |
The last commit adds 2 new tests for the functionality of starting Do you have some other dynamical system in mind to make a new test? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks a lot!
I'll merge it and release a new patch version. Thanks again! |
Closes #92.