Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#92 - Generalize input of validated integ #103

Merged
merged 5 commits into from
Mar 26, 2021

Conversation

mforets
Copy link
Contributor

@mforets mforets commented Mar 17, 2021

Closes #92.

@coveralls
Copy link

coveralls commented Mar 17, 2021

Pull Request Test Coverage Report for Build 661552514

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 53 (0.0%) changed or added relevant lines in 1 file are covered.
  • 669 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-56.5%) to 0.082%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/validatedODEs.jl 0 53 0.0%
Files with Coverage Reduction New Missed Lines %
src/promotion.jl 1 0.0%
src/show.jl 13 0.0%
src/auxiliary.jl 29 0.0%
src/constructors.jl 29 0.0%
src/integration.jl 31 0.0%
src/evaluate.jl 40 0.0%
src/rpa_functions.jl 101 0.0%
src/arithmetic.jl 122 0.0%
src/validatedODEs.jl 148 0.0%
src/bounds.jl 155 0.0%
Totals Coverage Status
Change from base Build 640233573: -56.5%
Covered Lines: 1
Relevant Lines: 1223

💛 - Coveralls

@mforets mforets changed the title #92 - Generalize input of validated integ #92 - WIP - Generalize input of validated integ Mar 17, 2021
@mforets
Copy link
Contributor Author

mforets commented Mar 17, 2021

I've updated the title of the PR because the branch is still WIP: some additional arguments need to be passed to the initialization functions (eg. orderT) while for others such as the symmetric intreval box I think it's better to define it as a function, say symIbox(N) = ....

@mforets mforets changed the title #92 - WIP - Generalize input of validated integ #92 - Generalize input of validated integ Mar 18, 2021
@mforets
Copy link
Contributor Author

mforets commented Mar 18, 2021

This is now ready for review. Tests pass locally (julia v1.5.2).

src/validatedODEs.jl Outdated Show resolved Hide resolved
@lbenet
Copy link
Member

lbenet commented Mar 20, 2021

Thanks a lot for addressing #92!

LGTM. Could you perhaps add some tests for the new method? (Maybe simply adapt the existing ones?)

@mforets
Copy link
Contributor Author

mforets commented Mar 22, 2021

for others such as the symmetric intreval box I think it's better to define it as a function, say symIbox(N) = ....

this could be defined in IntervalArithmetic.jl (see JuliaIntervals/IntervalArithmetic.jl#446)

@mforets
Copy link
Contributor Author

mforets commented Mar 26, 2021

Should we merge this? Or you'd like to add some further tests?

@lbenet
Copy link
Member

lbenet commented Mar 26, 2021

I would prefer to have some tests... it always helps!

@mforets
Copy link
Contributor Author

mforets commented Mar 26, 2021

The last commit adds 2 new tests for the functionality of starting validated_integ with a vector of TMs.

Do you have some other dynamical system in mind to make a new test?

Copy link
Member

@lbenet lbenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot!

@lbenet
Copy link
Member

lbenet commented Mar 26, 2021

I'll merge it and release a new patch version. Thanks again!

@lbenet lbenet merged commit d0d9b61 into JuliaIntervals:master Mar 26, 2021
@mforets mforets deleted the mforets/92 branch March 26, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generalize validated ODEs to receive an initial Taylor model
3 participants