Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve failing tests (validated_integ.jl) #126

Merged
merged 7 commits into from Nov 2, 2021
Merged

Solve failing tests (validated_integ.jl) #126

merged 7 commits into from Nov 2, 2021

Conversation

lbenet
Copy link
Member

@lbenet lbenet commented Oct 22, 2021

See this comment for the problem.

CompatHelper Julia and others added 3 commits October 17, 2021 00:27
@coveralls
Copy link

coveralls commented Oct 22, 2021

Pull Request Test Coverage Report for Build 1400889420

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 4 (50.0%) changed or added relevant lines in 1 file are covered.
  • 72 unchanged lines in 19 files lost coverage.
  • Overall coverage increased (+1.2%) to 64.675%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/validatedODEs.jl 2 4 50.0%
Files with Coverage Reduction New Missed Lines %
src/bounds.jl 1 94.41%
src/evaluate.jl 1 86.67%
src/show.jl 1 81.25%
src/Taylor1/draw.jl 1 0.0%
src/auxiliary.jl 2 55.22%
src/rpa_functions.jl 2 84.17%
src/Taylor1/bound.jl 2 0.0%
src/TaylorN/integrate.jl 2 0.0%
src/TaylorN/TaylorN.jl 2 0.0%
src/Taylor1/arithmetic.jl 3 0.0%
Totals Coverage Status
Change from base Build 1174353579: 1.2%
Covered Lines: 985
Relevant Lines: 1523

💛 - Coveralls

@lbenet
Copy link
Member Author

lbenet commented Oct 22, 2021

Since IntervalArithmetics.jl currently requires Julia 1.5, I guess it makes sense to require the same here at least; this would solve the broken tests (due to the introduction of numtype).

cc @lucaferranti

@lbenet
Copy link
Member Author

lbenet commented Oct 23, 2021

Should we require IntervalArithmetic v0.20 and later? And then bump a new minor version.

@schillic
Copy link
Contributor

Should we require IntervalArithmetic v0.20 and later?

Either that or you need to make the change eltypenumtype version dependent. (I guess it would fail with older versions of IA, which you do not see in the build here because it only uses the latest version.)

@lucaferranti
Copy link
Member

huups, apologies for not noticing you tagged me. Anyway, I agree with Christian that it may make sense to update the compatibilities with IA and Julia. The documentation check seems to fail, but it seems to be unrelated to this PR

@lbenet
Copy link
Member Author

lbenet commented Oct 30, 2021

@lucaferranti Thanks for the comment; do you understand the problem with the docs? Locally, I can't reproduce it.

@schillic
Copy link
Contributor

Have you tried retriggering? It could just be a random failure.

try to fix doc deployment
@lucaferranti
Copy link
Member

it was a plotting related issue, when Plots.jl is used with the GR backend, then it requires the small trick of my latest commit, more details here.

I am not sure why this didn't come up before, probably because this PR added Plots.jl as deps in the docs Project.toml

@lbenet
Copy link
Member Author

lbenet commented Nov 2, 2021

Thanks @lucaferranti for fixing this! So I'll merge and then tag the new version!

@lbenet lbenet merged commit 69161c1 into master Nov 2, 2021
@lbenet lbenet deleted the lb/numtype branch November 2, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants