Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples to the docs page #98

Merged
merged 3 commits into from
Jan 22, 2021

Conversation

mforets
Copy link
Contributor

@mforets mforets commented Jan 18, 2021

This PR brings the examples script (see here) to the main docs page.

I may contribute w/other subsections to that page (example use cases that come up frequently on the issues list of this repo / on Discourse), but we can go in stages.. :)

@mforets
Copy link
Contributor Author

mforets commented Jan 18, 2021

This PR is only an update to the docs. As you may know, Documenter has a feature to push a preview of the docs if you set push_preview=true in the call to deploydocs. Otherwise, you can pull this forked branch to build the docs locally with:

$ git fetch origin pull/98/head:pr/98 && git checkout pr/98

I always forget that trick :)

Copy link
Member

@lbenet lbenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution, @mforets!

I left a comment about the wording, which sounds better to me, but be aware that I'm not a native English speaker...

In addition, I'd like to suggest to use push_preview = true within the deploydocs function (in docs/make.jl). It allows to have a preview (online) of the docs; see this for the relevant documentation. (This may make life easier for #99.)

docs/src/index.md Outdated Show resolved Hide resolved
docs/src/index.md Outdated Show resolved Hide resolved
docs/src/index.md Outdated Show resolved Hide resolved
@mforets mforets mentioned this pull request Jan 20, 2021
@mforets
Copy link
Contributor Author

mforets commented Jan 22, 2021

@lbenet I've updated this branch with master, however i'm not sure if docs preview will work because the PR is made from my fork (I don't have rights to make it from JuliaIntervals).

@lbenet
Copy link
Member

lbenet commented Jan 22, 2021

Thanks a lot; I'll take a look on them later...

I think you need to rebase to master (and push again), since #100 has been merged. this should make possible to see the preview of the docs.

@mforets
Copy link
Contributor Author

mforets commented Jan 22, 2021

I think you need to rebase to master (and push again), since #100 has been merged. this should make possible to see the preview of the docs.

yes, i did just that. about my comment on the fork is about this Note:

Pull requests made from forks will not have previews. Hosting previews requires access to the deploy key. Therefore, previews are available only for pull requests that were submitted directly from the main repository.

@lbenet
Copy link
Member

lbenet commented Jan 22, 2021

Mmmm... you are right. Since the proposed changes LGTM, I guess we can simply go ahead and merge them. Is this ready?

@mforets
Copy link
Contributor Author

mforets commented Jan 22, 2021

from my side it is ready 👌

@lbenet
Copy link
Member

lbenet commented Jan 22, 2021

Thanks a lot @mforets!! Merging.

@lbenet lbenet merged commit 7e8b31e into JuliaIntervals:master Jan 22, 2021
@mforets mforets deleted the mforets/examples branch January 22, 2021 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants