Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use current world_age instead of max #189

Merged
merged 3 commits into from
May 10, 2021
Merged

Use current world_age instead of max #189

merged 3 commits into from
May 10, 2021

Conversation

vchuravy
Copy link
Member

fixes #188

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2021

Codecov Report

Merging #189 (98f1e52) into master (52aaf98) will decrease coverage by 0.26%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
- Coverage   85.18%   84.91%   -0.27%     
==========================================
  Files           6        6              
  Lines         749      749              
==========================================
- Hits          638      636       -2     
- Misses        111      113       +2     
Impacted Files Coverage Δ
src/overdub.jl 95.98% <66.66%> (-0.33%) ⬇️
src/tagging.jl 72.00% <0.00%> (-0.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52aaf98...98f1e52. Read the comment docs.

@vchuravy
Copy link
Member Author

Might also fix: CliMA/Oceananigans.jl#1514 (comment)

@vchuravy vchuravy merged commit 44486d4 into master May 10, 2021
@vchuravy vchuravy deleted the vc/world_age branch May 10, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default value to reflect should be Base.current_world
2 participants