Skip to content
This repository has been archived by the owner on Jul 16, 2019. It is now read-only.

BufferedArray for MPI #7

Merged
merged 15 commits into from
Nov 9, 2018
Merged

BufferedArray for MPI #7

merged 15 commits into from
Nov 9, 2018

Conversation

shashi
Copy link
Contributor

@shashi shashi commented Nov 5, 2018

No description provided.

@vchuravy vchuravy self-requested a review November 6, 2018 02:27
Copy link
Member

@vchuravy vchuravy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we originally discussed splitting sync into two phases?


fill_sendbufs!(a, mesh)

sendreqs = fill(MPI.REQUEST_NULL, length(nbrranks))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sendreqs and recvreqs need to be part of BufferedArray, otherwise sync; sync; will do the wrong thing.

@shashi shashi merged commit b479ac1 into master Nov 9, 2018
@shashi shashi deleted the s/mpi branch November 9, 2018 00:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants