(WIP) Move codegen.cpp to a native Julia pipeline using the C interface + MLIR.jl #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
femtomc
commented
Apr 25, 2021
femtomc
commented
- Generating code for multiple test cases:
- code without Pi and Phi (simple single blocks, no type conversion)
- code with Pi and Phi
- tests cases in Brutus
- Executing code for multiple test cases:
- code without Pi and Phi (simple single blocks, no type conversion)
- code with Pi and Phi
- tests cases in Brutus
…s left to verify correctness with simple tests.
… remove modules and contexts in memory.
vchuravy
reviewed
Apr 25, 2021
| function emit_value(b::JLIRBuilder, loc::JLIR.Location, | ||
| value, ::Type) | ||
| type = typeof(value) | ||
| jlir_type = convert_type_to_jlirtype(b.ctx, type) |
There was a problem hiding this comment.
Instead of snake case, either convert(JLIRType, type, b.ctx) or JLIRType(b.ctx, type)
vchuravy
reviewed
Apr 25, 2021
| function emit_value(b::JLIRBuilder, loc::JLIR.Location, | ||
| value::Core.Argument, type::Type) | ||
| idx = value.n | ||
| arg = JLIR.get_arg(b.blocks[1], idx - 1) |
There was a problem hiding this comment.
arguments(b.blocks[1])[idx-1] or b.blocks[1][idx-1]?
femtomc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.