Ensure range returns valid indices #458
Conversation
| @@ -133,7 +133,7 @@ function sourcetext(node::AbstractSyntaxNode) | |||
| end | |||
|
|
|||
| function Base.range(node::AbstractSyntaxNode) | |||
| (node.position-1) .+ (1:span(node)) | |||
| node.position:prevind(node.source.code, node.position + span(node)) | |||
There was a problem hiding this comment.
It's intentional that range() specifically returns a byte range, so this part won't be correct without reviewing the other code.
(In fact, in a change I'm about to do, I'm renaming range() to byte_range()!)
There was a problem hiding this comment.
Ah, I see. I think it would be good to have some minimal docs about these things :)
Also, if it is supposed to not return string indices here, then there is probably some test missing that would actually fail with the changes in my PR here, right?
There was a problem hiding this comment.
Mm more docs would be good.
At some point this package went from "a hacky thing I dream of being the main parser" to "oh wait it's actually important but still incomplete" 😆
There was a problem hiding this comment.
(Or more accurately "Oh wait it's actually important but still incomplete and it's proximal to the work I'm actually paid for, but not part of what I'm paid for". A tricky place to be in mentally 😬)
This (maybe) kind of fixes #457. It at least ensures that
rangealways is a valid range that can be used to index into the source string, i.e. it moves the logic that fixes the indices returned bylast_bytefromBase.viewintoBase.range.Still wondering, though, whether the proper fix wouldn't be to do something about
span.