Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

Register and tag HarwellRutherfordBoeing #4116

Merged
merged 2 commits into from
Nov 30, 2015

Conversation

dpo
Copy link
Contributor

@dpo dpo commented Nov 29, 2015

No description provided.

@tkelman
Copy link
Contributor

tkelman commented Nov 29, 2015

Needs a minimum julia version requirement

@dpo
Copy link
Contributor Author

dpo commented Nov 29, 2015

Done.

@tkelman
Copy link
Contributor

tkelman commented Nov 29, 2015

@dpo
Copy link
Contributor Author

dpo commented Nov 29, 2015

that wasn't obvious.

@tkelman
Copy link
Contributor

tkelman commented Nov 29, 2015

Sorry about that. Pkg.tag takes the current content of your package's REQUIRE file and populates the METADATA files accordingly. The METADATA content is what actually gets used for dependency resolution by Pkg. So if you change the package data without subsequently re-tagging, the dependency data is not publicly known yet.

@dpo
Copy link
Contributor Author

dpo commented Nov 29, 2015

Oh yes, sorry. I meant pushing to the pull-request-xyz branch on my fork wasn't so obvious. Somehow Pkg.publish() managed to push to it without adding my fork as a remote.

@dpo
Copy link
Contributor Author

dpo commented Nov 29, 2015

@tkelman
Copy link
Contributor

tkelman commented Nov 29, 2015

DNS issues, not your fault. Will be fixed by travis-ci/travis-build#557

Registering this package LGTM, I think it's good to go if no comments otherwise for the next day or so.

tkelman added a commit that referenced this pull request Nov 30, 2015
Register and tag HarwellRutherfordBoeing
@tkelman tkelman merged commit 1b8c50c into JuliaLang:metadata-v2 Nov 30, 2015
@dpo
Copy link
Contributor Author

dpo commented Nov 30, 2015

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants