Tag GLVisualize.jl v0.2.3 #8982
Conversation
| Packing | ||
| UnicodeFun | ||
|
|
||
| Compat 0.18 |
There was a problem hiding this comment.
this was already listed above but at 0.9.5, should modify the existing minimum instead of listing it twice
|
Repository: JuliaGL/GLVisualize.jl --- 0.2.2/requires
+++ 0.2.3/requires
@@ -3,7 +3,6 @@
GLWindow 0.3
GLAbstraction 0.3.1
GeometryTypes 0.2
-Compat 0.9.5
GLFW
ModernGL
@@ -25,3 +24,5 @@
Iterators
Packing
UnicodeFun
+
+Compat 0.18cc: @SimonDanisch |
attobot
force-pushed
the
GLVisualize/v0.2.3
branch
from
22a26e9
to
0c60ac0
Compare
|
Woops... |
|
seems like I need to restrict the reactive version! |
|
Repository: JuliaGL/GLVisualize.jl --- 0.2.2/requires
+++ 0.2.3/requires
@@ -3,12 +3,11 @@
GLWindow 0.3
GLAbstraction 0.3.1
GeometryTypes 0.2
-Compat 0.9.5
GLFW
ModernGL
FixedSizeArrays
-Reactive
+Reactive 0.3.3 0.3.7
FixedPointNumbers
ColorVectorSpace
@@ -25,3 +24,5 @@
Iterators
Packing
UnicodeFun
+
+Compat 0.18cc: @SimonDanisch |
attobot
force-pushed
the
GLVisualize/v0.2.3
branch
from
0c60ac0
to
01e62d8
Compare
GLVisualize/versions/0.2.3/requires
Outdated
| GLFW | ||
| ModernGL | ||
| FixedSizeArrays | ||
| Reactive 0.3.3 0.3.7 |
There was a problem hiding this comment.
does this upper bound need to apply to all past versions?
There was a problem hiding this comment.
What do you mean? But I think the range is indeed wrong, since it won't include 0.3.7, no?
GLVisualize works with 0.3.3 - 0.3.7 right now...
There was a problem hiding this comment.
Upper bounds are exclusive. And what I mean is if you have an upper bound only on this newest version of GLVisualize, Pkg would be allowed to keep GLVisualize held back to 0.2.2 or earlier and upgrade Reactive to the latest. Would things work if it did that?
There was a problem hiding this comment.
Oh... No it wouldn't.
There was a problem hiding this comment.
What can be done about this?
There was a problem hiding this comment.
If the latest Reactive version broke all past tags of GLVisualize, then best thing to do is open a separate PR that adds Reactive upper bounds to all the past GLVisualize tags' require files. Don't touch the sha or the git tags, just the metadata copies of the require files.
There was a problem hiding this comment.
There was so much restructuring going on with Reactive, that I didn't realize that it was simply a bug: JuliaGizmos/Reactive.jl#136
So I guess this moves the problem to tagging reactive? We need to switch out the bugged tag with the bugfix tag?
There was a problem hiding this comment.
If prior versions work, and newer versions are going to work after the bugfix gets tagged, then I don't think you should have stricter bounds for it. You would want to avoid the particular single bugged version, and that is possible to express with bounds but it's a bit unintuitive and not many people have been doing disjoint ranges.
There was a problem hiding this comment.
that's why I asked if it's appropriate to just rewire Reactive's tag, so that the bugged version isn't in METADATA anymore...
There was a problem hiding this comment.
The buggy tag has been published for a while now, it should be superseded with a new tag but not modified in-place.
|
Repository: JuliaGL/GLVisualize.jl --- 0.2.2/requires
+++ 0.2.3/requires
@@ -3,12 +3,11 @@
GLWindow 0.3
GLAbstraction 0.3.1
GeometryTypes 0.2
-Compat 0.9.5
GLFW
ModernGL
FixedSizeArrays
-Reactive
+Reactive 0.4.1
FixedPointNumbers
ColorVectorSpace
@@ -25,3 +24,5 @@
Iterators
Packing
UnicodeFun
+
+Compat 0.18cc: @SimonDanisch |
attobot
force-pushed
the
GLVisualize/v0.2.3
branch
from
01e62d8
to
1ba9f62
Compare
|
Okay, so there shouldn't be any harm to merge this... |
| GLFW | ||
| ModernGL | ||
| FixedSizeArrays | ||
| Reactive 0.4.1 |
There was a problem hiding this comment.
do 0.3.x versions work?
If prior versions work, and newer versions are going to work after the bugfix gets tagged, then I don't think you should have stricter bounds for it.
There was a problem hiding this comment.
what's the minimum version then? what feature are you relying on? or bugfix before which none of the releases would work?
There was a problem hiding this comment.
Bug got introduced in 3.7, and got fixed in 4.1 - no version is working with the bug
There was a problem hiding this comment.
If there are versions prior to 0.3.7 that would work, then you shouldn't rule out installation of them.
|
Please do not do |
|
Repository: JuliaGL/GLVisualize.jl --- 0.2.2/requires
+++ 0.2.3/requires
@@ -3,12 +3,11 @@
GLWindow 0.3
GLAbstraction 0.3.1
GeometryTypes 0.2
-Compat 0.9.5
GLFW
ModernGL
FixedSizeArrays
-Reactive
+Reactive 0.4.1
FixedPointNumbers
ColorVectorSpace
@@ -25,3 +24,5 @@
Iterators
Packing
UnicodeFun
+
+Compat 0.18cc: @SimonDanisch |
attobot
force-pushed
the
GLVisualize/v0.2.3
branch
from
1ba9f62
to
900193a
Compare
|
@timholy supplied that code.. I believe the rational behind it was, that these packages are not needed for the old images, but when Images uses them, it will also require them. |
That's only enforceable if it's guaranteed that all allowed Images versions (will always) do so. With no upper bound, there's no way to ensure that. |
|
Well, it doesn't need to, since all code that is using this is in a similar conditional. I believe @timholy used this as a switch to verify if one is one the new version of Images that works with those packages. |
|
Please check that:
Then reply with |
|
specifically w.r.t Reactive,
|
|
So how do I do a version range from |
|
|
|
Thanks! ... Too easy. This is actually even pretty clearly stated in the docs... |
|
should be closed in favor of: #9436 |
Repository: JuliaGL/GLVisualize.jl
Release: v0.2.3
Diff: vs v0.2.2
requiresvs v0.2.2:cc: @SimonDanisch