Register new package GeneticVariation.jl v0.1.0 #9921
Conversation
|
Looks like BioSymbols is imported directly, so it should be listed directly in REQUIRE instead of assuming it's present as a transitive dependency |
| BioCore | ||
| BioSequences | ||
| BufferedStreams | ||
| Compat 0.18 |
There was a problem hiding this comment.
only need 0.17 for abstract type
|
@tkelman Is it imported directly? On the release-0.1 branch I removed an import of BioSymbols from src/GeneticVariation.jl because it turned out I didn't need it. It is still present on master, but when release-0.1 branch is made, any revisions on that branch will be merged back into master. |
|
Repository: BioJulia/GeneticVariation.jl Please make sure that:
@Ward9250 This PR will remain open for 24 hours for feedback (which is optional). If you get feedback, please let us know if you are making changes, and we'll merge once you're done. |
attobot
force-pushed
the
GeneticVariation/v0.1.0
branch
from
53752de
to
703dece
Compare
Ah yes you're right, I was looking at master, didn't realize this was tagged from a different branch |
|
@tkelman Before this merges, I'm going hotfix BioSequences.jl and add changes to this release to address your Tuple{Int,Int} zero comment first. |
|
@tkelman Ok I've made changes for the whole Base.zero thing. As a result this will depend on a hotfix version of BioSequences.jl, and that's reflected in REQUIRE, although I've just noticed attobot hasn't opened a PR for BioSequences.jl nor has it updated this thread. |
|
@simonbyrne did you tweak something on attobot? |
|
I've just deleted and redone the hotfix release for BioSequences.jl and attobot still hasn't responded. |
|
Open an issue on the attobot repo? |
|
I've done the BioSequences.jl PR myself using PkgDev.tag - PkgDev.publish in the meantime. |
|
Repository: BioJulia/GeneticVariation.jl Please make sure that:
@Ward9250 This PR will remain open for 24 hours for feedback (which is optional). If you get feedback, please let us know if you are making changes, and we'll merge once you're done. |
attobot
force-pushed
the
GeneticVariation/v0.1.0
branch
from
703dece
to
4697e79
Compare
|
Repository: BioJulia/GeneticVariation.jl Please make sure that:
@Ward9250 This PR will remain open for 24 hours for feedback (which is optional). If you get feedback, please let us know if you are making changes, and we'll merge once you're done. |
attobot
force-pushed
the
GeneticVariation/v0.1.0
branch
from
4697e79
to
7536e38
Compare
|
Ok back on track now. GeneticVariation now depends on BioSequences v0.6.2 in order to avoid the Base.zero definition, just redoing travis builds now to light that green. |
|
Repository: BioJulia/GeneticVariation.jl Please make sure that:
@Ward9250 This PR will remain open for 24 hours for feedback (which is optional). If you get feedback, please let us know if you are making changes, and we'll merge once you're done. |
attobot
force-pushed
the
GeneticVariation/v0.1.0
branch
from
7536e38
to
8fd030d
Compare
Repository: BioJulia/GeneticVariation.jl
Release: v0.1.0
Travis:
cc: @Ward9250
Please make sure that:
@Ward9250 This PR will remain open for 24 hours for feedback (which is optional). If you get feedback, please let us know if you are making changes, and we'll merge once you're done.