Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another attempt at cleaning up eof call #256

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Another attempt at cleaning up eof call #256

merged 1 commit into from
Aug 31, 2022

Conversation

quinnj
Copy link
Member

@quinnj quinnj commented Aug 30, 2022

Alternative solution to the attempt in JuliaWeb/HTTP.jl#912.

@quinnj quinnj requested a review from vtjnash August 30, 2022 20:37
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #256 (53d62cb) into master (b3ba37b) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
- Coverage   73.75%   73.74%   -0.01%     
==========================================
  Files          12       12              
  Lines         720      716       -4     
==========================================
- Hits          531      528       -3     
+ Misses        189      188       -1     
Impacted Files Coverage Δ
src/ssl.jl 72.56% <100.00%> (-0.04%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@quinnj quinnj merged commit 9cde72c into master Aug 31, 2022
@quinnj quinnj deleted the jq/eof branch August 31, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants