Some fixes to precompile "replay" #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #805 +/- ##
=======================================
Coverage 82.98% 82.98%
=======================================
Files 3 3
Lines 670 670
=======================================
Hits 556 556
Misses 114 114
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous strategy was to import all loaded packages into the "PrecompileStagingArea" and then execute the precompile statements. Here, I instead try to execute the precompile statement and if this throws an
UndefVarErrorI try import that symbol from the loaded modules. If there exist multiple loaded modules with that name, we ignore the statement.As a future improvement to ignoring the precompile statement could be to try executeing it with the different modules with the same name, one by one, until we manage to execute something that works.
Fixes #798
Fixes #767
With this PR I can precompile a sysimage of OmniPackage.jl which didn't work before.