Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow more statements in generate_precompile.jl #49200

Merged
merged 1 commit into from
Mar 31, 2023
Merged

allow more statements in generate_precompile.jl #49200

merged 1 commit into from
Mar 31, 2023

Conversation

JeffBezanson
Copy link
Sponsor Member

Since #47259 most Vararg precompile statements actually work, so they should be allowed, and for ones that don't work there's no harm in trying them.

A similar change is needed in PackageCompiler.

@JeffBezanson
allow more statements in generate_precompile.jl
6347cba 
Since #47259 most Vararg precompile statements actually work, so they should be
allowed, and for ones that don't work there's no harm in trying them.
@JeffBezanson JeffBezanson added compiler:precompilation Precompilation of modules compiler:latency Compiler latency labels Mar 30, 2023
@JeffBezanson
Copy link
Sponsor Member Author

Random example I encountered: precompile(Tuple{typeof(Base.typed_hcat), Type{Any}, Float64, Float64, Float64, Vararg{Any}}). This is a valid compilation signature that works just fine now.

@KristofferC KristofferC added the backport 1.9 Change should be backported to release-1.9 label Mar 31, 2023
@IanButterworth IanButterworth merged commit 9001ea0 into master Mar 31, 2023
@IanButterworth IanButterworth deleted the jb/moreprecompile branch March 31, 2023 13:23
@IanButterworth IanButterworth mentioned this pull request Mar 31, 2023
Closed
KristofferC pushed a commit that referenced this pull request Apr 9, 2023
@JeffBezanson @KristofferC
allow more statements in generate_precompile.jl (#49200)
8219ad5 
(cherry picked from commit 9001ea0)
@KristofferC KristofferC mentioned this pull request Apr 9, 2023
Merged
26 tasks
Xnartharax pushed a commit to Xnartharax/julia that referenced this pull request Apr 19, 2023
@JeffBezanson @Xnartharax
allow more statements in generate_precompile.jl (JuliaLang#49200)
5fbc7f9
KristofferC added a commit to JuliaLang/PackageCompiler.jl that referenced this pull request Apr 23, 2023
@KristofferC
disable vararg workaround on 1.9+
32b6ae0 
this should be fixed, ref JuliaLang/julia#49200
KristofferC added a commit to JuliaLang/PackageCompiler.jl that referenced this pull request Apr 23, 2023
@KristofferC
disable vararg workaround on 1.9+
7123a2c 
this should be fixed, ref JuliaLang/julia#49200
KristofferC added a commit to JuliaLang/PackageCompiler.jl that referenced this pull request Apr 23, 2023
@KristofferC
disable vararg workaround on 1.9+
57e5c4c 
this should be fixed, ref JuliaLang/julia#49200
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KristofferC KristofferC KristofferC approved these changes

Assignees
No one assigned
Labels
compiler:latency Compiler latency compiler:precompilation Precompilation of modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JeffBezanson @KristofferC @IanButterworth