Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bad/incorrect/missing handling of stdlibs in Manifest #3719

Closed
vtjnash opened this issue Dec 6, 2023 · 1 comment · Fixed by #3720
Closed

bad/incorrect/missing handling of stdlibs in Manifest #3719

vtjnash opened this issue Dec 6, 2023 · 1 comment · Fixed by #3720

Comments

@vtjnash
Copy link
Sponsor Member

vtjnash commented Dec 6, 2023

While investigating JuliaStats/Statistics.jl#134, I noticed that calling add Statistics fails to update the global Manifest correctly (does not add the extensions section or update the version) and if then delete the global Manifest and run resolve (which updates the Manifest correctly) then rm Statistics it again fails to update the global Manifest correctly and becomes wrong again (keeping the information for the non-stdlib copy) until I again manually delete the global Manifest
vtjnash added a commit that referenced this issue Dec 6, 2023
@vtjnash
extensions: fixup entire manifest
6d7f012 
Not just explicitly installed packages.

Do I understand this logic? No.

Do I understand if this fixes anything? No.

Fixes #3719
@vtjnash vtjnash mentioned this issue Dec 6, 2023
Merged
@vtjnash vtjnash closed this as completed Dec 6, 2023
@IanButterworth IanButterworth reopened this Dec 6, 2023
@KristofferC
Copy link
Sponsor Member

I noticed that calling add Statistics fails to update the global Manifest correctly (does not add the extensions section or update the version)

Wasn't the issue here that 1.11 was not merged into the registry? Probably fixed now after JuliaRegistries/General#96654 is merged?

KristofferC pushed a commit that referenced this issue Apr 5, 2024
@vtjnash
extensions: fixup entire manifest (#3720)
77620a9 
Not just explicitly installed packages.

Do I understand this logic? No.

Do I understand if this fixes anything? No.

Fixes #3719
KristofferC pushed a commit that referenced this issue May 9, 2024
@vtjnash
extensions: fixup entire manifest (#3720)
15686ed 
Not just explicitly installed packages.

Do I understand this logic? No.

Do I understand if this fixes anything? No.

Fixes #3719
KristofferC pushed a commit that referenced this issue Jul 5, 2024
@vtjnash @KristofferC
extensions: fixup entire manifest (#3720)
174404a 
Not just explicitly installed packages.

Do I understand this logic? No.

Do I understand if this fixes anything? No.

Fixes #3719
IanButterworth pushed a commit that referenced this issue Jul 23, 2024
@vtjnash @IanButterworth
extensions: fixup entire manifest (#3720)
99f6754 
Not just explicitly installed packages.

Do I understand this logic? No.

Do I understand if this fixes anything? No.

Fixes #3719

(cherry picked from commit 77620a9)
IanButterworth pushed a commit that referenced this issue Jul 23, 2024
@vtjnash @IanButterworth
extensions: fixup entire manifest (#3720)
d092845 
Not just explicitly installed packages.

Do I understand this logic? No.

Do I understand if this fixes anything? No.

Fixes #3719
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

extensions: fixup entire manifest JuliaLang/Pkg.jl
3 participants
@vtjnash @KristofferC @IanButterworth