Clarify activate command signatures #2037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The signatures in the help for the activate command were confusing. It seemed to imply that the `activate --shared` and `activate --temp` each took an optional path, when in fact `activate --shared` requires a path and `activate --temp` does not accept a path. This clarifies the command signatures for these two cases.
fredrikekre
approved these changes
Sep 23, 2020
|
I restarted the doc build; the macOS Travis failures are unrelated (due to PCRE upgrade). |
|
Is the best way to restart tests still to close then open the PR? |
|
I'm merging because macOS tests are all green, not sure why this is still pointing to Travis tests (seems we do not use it at all anymore) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signatures in the help for the activate command were confusing. It seemed to imply that the
activate --sharedandactivate --tempeach took an optional path, when in factactivate --sharedrequires a path andactivate --tempdoes not accept a path. This clarifies the command signatures for these two cases.