Windows: prefer git cloning registries (close #2014) #2175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since untarring a tarball like the registry is so slow on Windows, we prefer to git clone registries instead. Git is slow on Windows as well, but git updates are faster since git only updates the files that need to be modified, which is much faster than unpacking a whole new registry.
|
Can we backport this to 1.6? |
|
Can and should. To 1.5 also, if we're going to do any more releases off that version (which we should, imo). |
StefanKarpinski
added
backport pending 1.5
backport 1.6
|
I wonder if not #2186 caused a lot of the slowness..., not untarring. Probably a combination of both. |
KristofferC
pushed a commit
that referenced
this pull request
Nov 1, 2020
Since untarring a tarball like the registry is so slow on Windows, we prefer to git clone registries instead. Git is slow on Windows as well, but git updates are faster since git only updates the files that need to be modified, which is much faster than unpacking a whole new registry. (cherry picked from commit 7297ccf)
|
Probably both. |
|
Found this one: microsoft/Windows-Dev-Performance#27 - there seems to be a possible communication channel to the windows devs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since untarring a tarball like the registry is so slow on Windows,
we prefer to git clone registries instead. Git is slow on Windows
as well, but git updates are faster since git only updates the
files that need to be modified, which is much faster than unpacking
a whole new registry.