Remove BinaryPlatforms_compat #3017
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This no longer appears to be necessary, and having extra methods of functions like Base.BinaryPlatforms.libgfortran_version has a cost: it becomes impossible for abstract inference to succeed, since it pushes the number of methods over `MAX_METHODS`.
timholy
force-pushed
the
teh/del_bp_compat
branch
from
cf5322d
to
b58f6bd
Compare
|
This is harder than I thought. I'm going to close this for now, but if someone who knows more about the JLL ecosystem can sketch a path forward I'd be happy to try again. |
This was referenced Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This no longer appears to be necessary, and having extra methods of
functions like Base.BinaryPlatforms.libgfortran_version has a cost: it
becomes impossible for abstract inference to succeed, since it pushes
the number of methods over
MAX_METHODS.