Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no longer consider DelimitedFiles an stdlib even though it is stored in stdlib folder #3373

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

KristofferC
Copy link
Sponsor Member

No description provided.

@KristofferC KristofferC changed the title no longer consider DelimtiedFiles an stdlib even though it is stored in stdlib folder no longer consider DelimitedFiles an stdlib even though it is stored in stdlib folder Feb 14, 2023
Copy link
Member

@DilumAluthge DilumAluthge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means that every time we move a new stdlib out, we need to update this file in Pkg, and then update Pkg in Julia master, right?

Could we instead have Pkg look for a file somewhere in Julia itself, e.g. stdlib/not-stdlibs.txt, and read the information from that? So then we don't have to update Pkg ever time we move a new stdlib out?

Copy link
Member

@DilumAluthge DilumAluthge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can just hard-code it for now, and then come up with a more sustainable solution later.

@KristofferC KristofferC merged commit 835cc30 into master Feb 20, 2023
@KristofferC KristofferC deleted the kc/delimited_files_no_stdlib branch February 20, 2023 13:45
KristofferC added a commit that referenced this pull request Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants