Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Pkg.jl invalidations #3712

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mkitti
Copy link
Contributor

@mkitti mkitti commented Nov 28, 2023

  • Move Pkg.BinaryPlatforms to Base.BinaryPlatforms.PkgCompat
  • Move UnstableIO to Base

Corresponding Julia PR (merge this first):
JuliaLang/julia#52249

Fix #3702 . No more invalidations.

julia> using SnoopCompileCore

julia> invalidations = @snoopr begin
           using Pkg
           Pkg.activate()
       end
  Activating project at `~/.julia/environments/v1.11`
2-element Vector{Any}:
 MethodInstance for Base.typeinfo_implicit(::Any)
 "invalidate_mt_cache"

julia> using SnoopCompile
Precompiling SnoopCompile
  4 dependencies successfully precompiled in 78 seconds. 58 already precompiled.
[ Info: Precompiling SnoopCompile [aa65fe97-06da-5843-b5b1-d5d13cad87d2]

julia> trees = invalidation_trees(invalidations)
SnoopCompile.MethodInvalidations[]

@mkitti mkitti marked this pull request as draft November 28, 2023 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pkg.BinaryPlatforms invalidates Base.BinaryPlatforms
1 participant