Automatically add compat entries when adding deps to a package #3732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanButterworth
added
needs changelog
needs docs
and removed
needs changelog
needs docs
labels
IanButterworth
force-pushed
the
ib/add_compat
branch
from
bd46769
to
0a19a9e
Compare
KristofferC
pushed a commit
that referenced
this pull request
May 9, 2024
* add compat entries when adding to a package * update tests that assume there's no compat entries * Update CHANGELOG.md * add docs * fix qualification * wording tweaks * add tests * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #776
If the current environment is a package this makes
pkg> addauto add compat entries for the new direct dependencies.I don't think we'd want to make this standard practice for the default envs, hence being specific to packages, but maybe there's an argument that it should be done for unnamed environments other than the defaults? Like the envs stored alongside scripts.
The compat entries are set to be lower-bounded by the installed patch version (which makes this work for JLLs).
It feels safer than relying on semver and setting it to
Base.thisminor(v).