New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: App support in Pkg #3772
base: master
Are you sure you want to change the base?
WIP: App support in Pkg #3772
Conversation
Oh this looks very cool! Thanks for all the time/effort that's gone into this 🤩 One thing I'm slightly concerned about here is the approach taken to making sure that the executables are on the users's
I see in the design document there is some mention of putting such files in a more standard location already on the path such as Other lang's package managers already install things in the XDG-appropriate locations, such as Python with I'd advocate for a (NB: when I say |
|
||
function bash_shim(pkgname, julia_executable_path::String, env) | ||
return """ | ||
#!/usr/bin/env bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On a briefer note, shouldn't the unix shim be based on sh
not bash
, possibly even #!/bin/sh
over #!/usr/bin/env sh
(somebody else should check, but IIRC that's the POSIX form)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Somebody else" is apparently me 😄, and my "IIRC" was wrong.
I've just had a look at https://pubs.opengroup.org/onlinepubs/009695399/utilities/sh.html and under APPLICATION USAGE there's this relevant excerpt:
Applications should note that the standard PATH to the shell cannot be assumed to be either /bin/sh or /usr/bin/sh, and should be determined by interrogation of the PATH returned by getconf PATH , ensuring that the returned pathname is an absolute pathname and not a shell built-in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From reading around a bit more, it seems like the consensus on portability goes something like this (from most portable to least):
- A binary executable that doesn't have a shebang
#!/bin/sh
#!/usr/bin/env sh
#!/usr/bin/env bash
#!/bin/bash
nice work! I'm wondering how apps are shared across Julia versions? e.g. are they isolated by Julia versions like how the global environment are setup? |
This seems useful, maybe already dispute that limitation. Could it be lifted by autoinstalling Julia (runtime, right version) for you if not available? Needs not be in first version. This is in some ways similar to Python's zipapps (which I believe is not too popular, because runtime can't be assumed, even for Linux where it's most often preinstalled), that needs separate .pyz[w] file ending, and Python installed (and are in one archive file, optionally compressed): https://docs.python.org/3/library/zipapp.html
[We already have AppBundler.jl if you want to bundle the runtime, it's best if you can have one way to make an app and it can be compiled with PackageCompiler, or use AppBundler, or a combining those..., or this system. ] |
With regards to XDG there is an argument that Pkg should follow what Julia itself does. (As you are aware) there is JuliaLang/julia#4630. A related question, according to XDG where should the For Windows the Cargo issue comment says:
How is that translated to all the files used here (shims,
I get
|
As it is right now each app entry in AppManifest.toml has an absolute path to a Julia installation. If you want to update that Julia version you would also resolve the environment. This ties into this later comment:
one plan forward is to use Juliaup to install the Julia installation that the app is currently configured for if it does not exist. That way you would not store the absolute path to the julia installation like that. |
Right. I basically see Julia as currently being in a similar situation to Cargo — in that by the end of JuliaLang/julia#4630 I think I can fairly summarise the consensus as "yes this would be nice to have, but it's going to be a hassle to start using it". Much of the value of the XDG Desktop spec comes via a network effect. Thus when the Desktop spec was new and that issue was created in 2013, the benefit was somewhat speculative. Now though, as more tools use and assume XDG compliance, it creates a growing tension between the "Julia way" and the XDG way. In this sort of light, I see decisions like this as opportunities to choose between digging down and digging out 😛 somewhat. I still have loose plans to go back to JuliaLang/julia#4630 to see if I can help move the state of affairs closer to XDG compliance (Stefan asked me if I'd be interested in putting a PR together a few months ago, and I am once I have fewer PRs currently open). Considering the current "Julia way" and the XDG spec, would it not be possible to put things in
I made a flowchart for answering this sort of question in the BaseDirs.jl docs which might be helpful (it's not 100% accurate, but I didn't want to make it more complicated, and I think it gets 98% of the way). If we classify
then Data Home would be the relevant XDG Desktop component (let me know if any of those assumptions don't hold). More generally, I find
A while ago I spent an inordinate amount of time looking at the relevant behaviour/specs/comments around directories on Windows/Mac. I think I'd probably be best off pointing you to the comparison table on https://tecosaur.github.io/BaseDirs.jl/stable/defaults/ (and if you want the reasoning/links to some of the most relevant resources: https://tecosaur.github.io/BaseDirs.jl/stable/others/). Regarding just this part of the comment:
Yea, getting the right system dirs on windows is actually a bit of a pain. See https://github.com/tecosaur/BaseDirs.jl/blob/main/src/nt.jl for a glimpse of me not having a fun time. |
My plan generally is that the Julia version in a manifest becomes the version selector for Juliaup. Presumably that would work well for apps here too? |
What is still needed before this can be merged? |
This is quite heavily WIP towards having "app" support in Pkg. An app is a program that you just write its name in the terminal and it starts up, without explicitly having to invoke Julia, load the package, and call a function. Every app has an isolated environment.
More details of the design can be found in this hackmd: https://hackmd.io/r0sgJar5SpGNomVB8wRP_Q
This PR requires JuliaLang/julia#52103
Here is some example usage:
cc @MasonProtter, @Roger-luo