More consistent legacy color conversion #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tecosaur
force-pushed
the
more-consistent-legacy-color-conversion
branch
from
256931e
to
eb4f1ed
Compare
When a given "legacy color" argument is not in fact a recognised color name, `legacy_color` should return nil, and indeed it does when the argument is a string. However, the color symbol method will just return the symbol argument if it is not recognised, creating an inconsistency in the behaviour. Instead, it should return nothing, as the string case does. This change is made, and a little of the surrounding code rearranged for clarity.
tecosaur
force-pushed
the
more-consistent-legacy-color-conversion
branch
from
eb4f1ed
to
7ce4e69
Compare
|
This is a minor change, with pretty straightforward justification/details, so I'm inclined to just go ahead and merge it. |
KristofferC
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Feb 15, 2024
Can be seen as a follow-on from #51829, also wants JuliaLang/StyledStrings.jl#37 to behave as expected.
tecosaur
added a commit
to tecosaur/julia
that referenced
this pull request
Mar 4, 2024
Can be seen as a follow-on from JuliaLang#51829, also wants JuliaLang/StyledStrings.jl#37 to behave as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a given "legacy color" argument is not in fact a recognised color
name,
legacy_colorshould return nil, and indeed it does when theargument is a string.
However, the color symbol method will just return the symbol argument if
it is not recognised, creating an inconsistency in the behaviour.
Instead, it should return nothing, as the string case does.
This change is made, and a little of the surrounding code rearranged for
clarity.