More cautious legacy_color conversion in Logging #53280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tecosaur
added
domain:display and printing
vtjnash
reviewed
Feb 11, 2024
While the original line
color = StyledStrings.Face(foreground=StyledStrings.Legacy.legacy_color(color))
does a perfectly adequate job of mapping old color names to
`SimpleColor`s, it neglects the newer capability of using named `Faces`
with logging.
It is better to first check that the value of `color` can indeed be
recognised as a `legacy_color`-compatible named color, before using it
as the foreground value.
tecosaur
force-pushed
the
more-careful-face-use-in-logging
branch
from
9bb4068
to
d222762
Compare
|
I think this should be able to be "just merged" |
oscardssmith
approved these changes
Feb 15, 2024
|
I goofed with the commit msg... |
tecosaur
added a commit
to tecosaur/julia
that referenced
this pull request
Mar 4, 2024
Can be seen as a follow-on from JuliaLang#51829, also wants JuliaLang/StyledStrings.jl#37 to behave as expected.
KristofferC
pushed a commit
that referenced
this pull request
May 10, 2024
This reverts commit 61c3521.
aviatesk
pushed a commit
that referenced
this pull request
May 13, 2024
This reverts commit 61c3521.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be seen as a follow-on from #51829, also wants
JuliaLang/StyledStrings.jl#37
to behave as expected.