Skip to content

Commit

Permalink
Merge pull request #19366 from ararslan/aa/gc-assertion
Browse files Browse the repository at this point in the history 
RFC: Disable GC state assertion when threading is disabled
  • Loading branch information
@yuyichao
yuyichao committed Nov 22, 2016
2 parents 68af05e + bf45a80 commit 2a4b68a
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/gc.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -818,7 +818,9 @@ JL_DLLEXPORT jl_value_t *jl_gc_pool_alloc(jl_ptls_t ptls, int pool_offset,
// to workaround a llvm bug.
// Ref https://llvm.org/bugs/show_bug.cgi?id=27190
jl_gc_pool_t *p = (jl_gc_pool_t*)((char*)ptls + pool_offset);
#ifdef JULIA_ENABLE_THREADING
assert(ptls->gc_state == 0);
#endif
#ifdef MEMDEBUG
return jl_gc_big_alloc(ptls, osize);
#endif
Expand Down

2 comments on commit 2a4b68a

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily benchmark build, I will reply here when finished:

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels

Please sign in to comment.