Fix return value in asyncmap! (#23906)

JuliaLang · Sep 28, 2017 · 4d2e1d7 · 4d2e1d7
1 parent 91b75cd
commit 4d2e1d7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/base/asyncmap.jl b/base/asyncmap.jl
@@ -420,5 +420,5 @@ returning a collection.
 """
 function asyncmap!(f, r, c1, c...; ntasks=0, batch_size=nothing)
     foreach(identity, AsyncCollector(f, r, c1, c...; ntasks=ntasks, batch_size=batch_size))
-    c
+    r
 end
diff --git a/test/abstractarray.jl b/test/abstractarray.jl
@@ -686,8 +686,9 @@ function test_map(::Type{TestAbstractArray})
     # Map to destination collection
     map!((x,y,z)->x*y*z, A, Float64[1:10...], Float64[1:10...], Float64[1:10...])
     @test A == map(x->x*x*x, Float64[1:10...])
-    Base.asyncmap!((x,y,z)->x*y*z, B, Float64[1:10...], Float64[1:10...], Float64[1:10...])
+    C = Base.asyncmap!((x,y,z)->x*y*z, B, Float64[1:10...], Float64[1:10...], Float64[1:10...])
     @test A == B
+    @test B === C
 end
 
 @testset "issue #15689, mapping an abstract type" begin