Skip to content

Commit

Permalink
Export bitbroadcast from Base
Browse files Browse the repository at this point in the history
  • Loading branch information
@carlobaldassi
carlobaldassi committed Mar 9, 2014
1 parent 63e483c commit b871f72
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions base/exports.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -470,6 +470,7 @@ export
zeta,

# arrays
bitbroadcast,
broadcast!,
broadcast!_function,
broadcast,
Expand Down

2 comments on commit b871f72

@JeffBezanson
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not very satisfying to need this function. It seems very specific.

@carlobaldassi
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first, I was thinking of not exporting it. Then I considered this: 1) broadcast! alone would be sufficient, but allocating the right size involves using broadcast_shape which is not exported and not too friendly 2) it seems to me that the bit- prefix goes along nicely with other BitArray-related functions, i.e. bitpack and bitunpack. So in the end my reasoning was basically along the lines of "why not?". It's fine with me to un-export and un-document.

Please sign in to comment.