move BLAS utils into BLAS module #16600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs corresponding rst doc update. Also mentioned in |
JeffBezanson
force-pushed
the
jb/blasutils
branch
from
075f582
to
5b0be73
Compare
|
AV hang again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This consolidates things and removes the
blas_set_num_threadsexport, which should pretty obviously just be part of the BLAS module.We also have
fftw_vendorin Base, but it's not exported, and is also complicated by the fact that FFTW is sometimes excluded, so I'll leave that for another time.[closes #10548]