-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using new Cartesian tools for copy! #5411
Comments
I'm fine with that, and I also understand if people have reservations about Cartesian invading base too deeply. Since it's my baby I probably don't have the best perspective on this, so I will defer to the wisdom of others. |
Paradoxically, I want Cartesian to invade base because I want it to go away. To explain that a bit further, what I'd like is for this Cartesian code to serve to help us understand exactly what we need from language features to replace all of it. |
That's a very reasonable thought. However, the reality is probably that many of the remaining applications in I'm happy do all the conversions myself, as anything "easy" would not take me long. But if others want to tackle some of these as an exercise in learning more about how it all works---and therefore what we need to do to ditch Cartesian---I'm happy to let you have at it. |
No, feel free. You can probably shave another 500 lines off of Base ;-) |
At this point we should only use it where there are performance problems (e.g. SubArray) and/or where the existing code is ugly anyway. |
Or where we can avoid using linear indexing and thereby make the algorithm more generic. |
Implemented in #5671. |
We should reimplement the
copy!
function for abstract arrays using @timholy's new Cartesian tools.The text was updated successfully, but these errors were encountered: