Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REPL stdout output should not be highlighted in code examples #54399

Closed
fredrikekre opened this issue May 8, 2024 · 1 comment · Fixed by #54423
Closed

REPL stdout output should not be highlighted in code examples #54399

fredrikekre opened this issue May 8, 2024 · 1 comment · Fixed by #54423
Assignees
@tecosaur
Labels
display and printing Aesthetics and correctness of printed representations of objects. markdown

Comments

@fredrikekre
Copy link
Member

For example from ?sum:
image
@tecosaur
Copy link
Contributor

tecosaur commented May 8, 2024

I have code to handle this properly, but Jameson (softly) veto'd it with the original PR: #51928 (comment).

I'll can PR this separately fairly shortly, but I might try to bump JuliaSyntaxHighlighting first.

@tecosaur tecosaur added the display and printing Aesthetics and correctness of printed representations of objects. label May 8, 2024
@tecosaur tecosaur mentioned this issue May 9, 2024
Merged
fredrikekre pushed a commit that referenced this issue May 10, 2024
@tecosaur
Highlight julia-repl code in Markdown specially (#54423)
6582eaa 
Fixes #54399 by re-introducing the code seperated out from the styled
Markdown PR at Jameson's request
(#51928 (comment)).

The code itself is modelled after [equivalent code in
OhMyREPL](https://github.com/KristofferC/OhMyREPL.jl/blob/b0071f5ee785a81ca1e69a561586ff270b4dc2bb/src/MarkdownHighlighter.jl#L15-L31).

The new `markdown_julia_prompt` face allows people to make the "prompt"
shown in Markdown code visually distinct, to [avoid confusing it with
the REPL prompt at a
glance](KristofferC/OhMyREPL.jl#100). By way
of example, I make it italic by augmenting my `faces.toml` with

```toml
[markdown]
julia_prompt = { italic = true }
```
lazarusA pushed a commit to lazarusA/julia that referenced this issue Jul 12, 2024
@tecosaur @lazarusA
Highlight julia-repl code in Markdown specially (JuliaLang#54423)
02895d7 
Fixes JuliaLang#54399 by re-introducing the code seperated out from the styled
Markdown PR at Jameson's request
(JuliaLang#51928 (comment)).

The code itself is modelled after [equivalent code in
OhMyREPL](https://github.com/KristofferC/OhMyREPL.jl/blob/b0071f5ee785a81ca1e69a561586ff270b4dc2bb/src/MarkdownHighlighter.jl#L15-L31).

The new `markdown_julia_prompt` face allows people to make the "prompt"
shown in Markdown code visually distinct, to [avoid confusing it with
the REPL prompt at a
glance](KristofferC/OhMyREPL.jl#100). By way
of example, I make it italic by augmenting my `faces.toml` with

```toml
[markdown]
julia_prompt = { italic = true }
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tecosaur tecosaur

Labels
display and printing Aesthetics and correctness of printed representations of objects. markdown
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Highlight julia-repl code in Markdown specially tecosaur/julia
2 participants
@fredrikekre @tecosaur