Pair construction can bork convert

[timholy]

A minimal testcase for the issue reported here:

julia> immutable RGB
           r::Float32
           g::Float32
           b::Float32
       end

julia> 
WARNING: deprecated syntax "{a=>b, ...}".
Use "Dict{Any,Any}(a=>b, ...)" instead.
julia> const colormaps_sequential = {
           #single hue
           #name        hue   w     d     c     s     b     wcolor      dcolor
           "blues"   => (255, 0.3,  0.25, 0.88, 0.6,  0.75, RGB(1,1,0), RGB(0,0,1)),
           "greens"  => (120, 0.15, 0.18, 0.88, 0.55, 0.9,  RGB(1,1,0), RGB(0,0,1)),
           "grays"   => (0,   0.0,  0.0,  1.0,  0.0,  0.75, RGB(1,1,0), RGB(0,0,1)),
           "oranges" => (20,  0.5,  0.4,  0.83, 0.95, 0.85, RGB(1,1,0), RGB(1,0,0)),
           "purples" => (265, 0.15, 0.2,  0.88, 0.5,  0.7,  RGB(1,0,1), RGB(1,0,0)),
           "reds"    => (12,  0.15, 0.25, 0.8,  0.85, 0.6,  RGB(1,1,0), RGB(0.3,0.1,0.1))
       }

WARNING: deprecated syntax "{a=>b, ...}".
Use "Dict{Any,Any}(a=>b, ...)" instead.
Dict{Any,Any} with 6 entries:
  "reds"    => (12,0.15,0.25,0.8,0.85,0.6,RGB(1.0f0,1.0f0,0.0f0),RGB(0.3f0,0.1f0,0.1f0))
  "purples" => (265,0.15,0.2,0.88,0.5,0.7,RGB(1.0f0,0.0f0,1.0f0),RGB(1.0f0,0.0f0,0.0f0))
  "oranges" => (20,0.5,0.4,0.83,0.95,0.85,RGB(1.0f0,1.0f0,0.0f0),RGB(1.0f0,0.0f0,0.0f0))
  "greens"  => (120,0.15,0.18,0.88,0.55,0.9,RGB(1.0f0,1.0f0,0.0f0),RGB(0.0f0,0.0f0,1.0f0))
  "blues"   => (255,0.3,0.25,0.88,0.6,0.75,RGB(1.0f0,1.0f0,0.0f0),RGB(0.0f0,0.0f0,1.0f0))
  "grays"   => (0,0.0,0.0,1.0,0.0,0.75,RGB(1.0f0,1.0f0,0.0f0),RGB(0.0f0,0.0f0,1.0f0))

julia> 
WARNING: deprecated syntax "{a=>b, ...}".
Use "Dict{Any,Any}(a=>b, ...)" instead.
julia> const colormaps_diverging = {
           #name         h1   h2    w     d1    d2    c      s     b      wcolor      dcolor      dcolor2
           "rdbu"    => (12,  255,  0.2,  0.6,  0.0,  0.85,  0.6,  0.65,  RGB(1,1,0), RGB(1,0,0), RGB(0,0,1))
       }

WARNING: deprecated syntax "{a=>b, ...}".
Use "Dict{Any,Any}(a=>b, ...)" instead.
Dict{Any,Any} with 1 entry:
  "rdbu" => (12,255,0.2,0.6,0.0,0.85,0.6,0.65,RGB(1.0f0,1.0f0,0.0f0),RGB(1.0f0,0.0f0,0.0f0),RGB(0.0f0,0.0f0,1.0f0))

And now:

julia> convert((Int...), (uint(1),))
ERROR: `convert` has no method matching convert(::Type{Int64...}, ::Uint64)
 in convert at base.jl:9
 in convert at base.jl:17

[timholy]

That's just a copy-paste of the maps_data.jl file from Color.

[timholy]

Actually, even if you use the new syntax, the error remains.

[timholy]

An even more minimal case:

julia> immutable RGB
           r::Float32
           g::Float32
           b::Float32
       end

julia> const colormaps_sequential = Dict(
           "blues"   => (255, 0.3,  0.25, 0.88, 0.6,  0.75, RGB(1,1,0), RGB(0,0,1)))
Dict{ASCIIString,(Int64,Float64,Float64,Float64,Float64,Float64,RGB,RGB)} with 1 entry:
  "blues" => (255,0.3,0.25,0.88,0.6,0.75,RGB(1.0f0,1.0f0,0.0f0),RGB(0.0f0,0.0f0,1.0f0))

julia> convert((Int...), (uint(1),))
ERROR: `convert` has no method matching convert(::Type{Int64...}, ::Uint64)
 in convert at base.jl:9
 in convert at base.jl:17

[simonster]

Even more minimal:

julia> 1 => (1,1,1,1,1,1,1,1,1.,false);

julia> convert((Int...), (uint(1),))
ERROR: `convert` has no method matching convert(::Type{Int64...}, ::Uint64)
 in convert at base.jl:9
 in convert at base.jl:17

[JeffBezanson]

Good, this is the level of breakage I was hoping to get to in 0.4-devel :) On the other hand, oh f*** there goes my week.

[timholy]

I sympathize. Meanwhile, I'll be curious to see whether this might be the same bug that's also behind #8618, #8128 (which seems to be working now, even though #8618 is not). Those others aren't obviously pair-related, of course, so the pessimistic view is that there is more than one 😦.

[jakebolewski]

Playing around with this

julia> 1=>(1,1,1,1,false)
1=>(1,1,1,1,false)

julia> convert((Int...), (uint(1),))
(1,)

julia> 1=>(1,1,1,1,1,false)
1=>(1,1,1,1,1,false)

julia> convert((Int...), (uint(1),))
ERROR: `convert` has no method matching convert(::Type{Int64...}, ::Uint64)

julia> 1=>(1,1,1,1,2.0)
1=>(1,1,1,1,2.0)

julia> convert((Int...), (uint(1),))
(1,)

julia> 1=>(1,1,1,1,1,2.0)
1=>(1,1,1,1,1,2.0)

julia> convert((Int...), (uint(1),))
ERROR: `convert` has no method matching convert(::Type{Int64...}, ::Uint64)

julia> 1=>(1,1,1,1,1,2.0,1)
1=>(1,1,1,1,1,2.0,1)

julia> convert((Int...), (uint(1),))
(1,)

julia> 1=>(1,1,1,1,1,1,2.0,1)
1=>(1,1,1,1,1,1,2.0,1)

julia> convert((Int...), (uint(1),))
ERROR: `convert` has no method matching convert(::Type{Int64...}, ::Uint64)

julia> 1=>(1.0,2,3,4, false)
1=>(1.0,2,3,4,false)

julia> convert((Int...), (uint(1),))
(1,)

julia> 1=>(1.0,2,3,4,5, false)
1=>(1.0,2,3,4,5,false)

julia> convert((Int...), (uint(1),))
ERROR: `convert` has no method matching convert(::Type{Int64...}, ::Uint64)

julia> 1=>(false,1.0,2,3,4)
1=>(false,1.0,2,3,4)

julia> convert((Int...), (uint(1),))
(1,)

julia> 1=>(false,1.0,2,3,4,5)
1=>(false,1.0,2,3,4,5)

julia> convert((Int...), (uint(1),))
ERROR: `convert` has no method matching convert(::Type{Int64...}, ::Uint64)

julia> 1 => (false,1,2,3,4,5)
1=>(false,1,2,3,4,5)

julia> convert((Int...), (uint(1),))
(1,)

So it seems like it is potentially related to these magic numbers although I don't offhand know why it starts at N+1.

[jakebolewski]

Actually changing those numbers does not seem to impact behavior.

[garborg]

In case it's not old news, convert is breaking for me on 0.3:

julia> aa = convert(Array{Ufixed8}, a)
ERROR: `convert` has no method matching convert(::Type{Array{UfixedBase{Uint8,8},N}}, ::Array{Float64,2})
 in convert at base.jl:13

julia> Pkg.status()
ERROR: `convert` has no method matching convert(::Type{UTF8String}, ::ASCIIString)
 in convert at base.jl:13
 in dir at pkg/git.jl:10
 in git at pkg/git.jl:16
 in success at pkg/git.jl:27
 in iscommit at pkg/git.jl:44
 in installed_version at ./pkg/read.jl:65
 in installed at ./pkg/read.jl:122
 in status at pkg/entry.jl:107
 in anonymous at pkg/dir.jl:28
 in cd at ./file.jl:20
 in cd at pkg/dir.jl:28
 in status at pkg.jl:28 (repeats 2 times)

julia> versioninfo()
Julia Version 0.3.2-pre+48
Commit bf35ce6 (2014-10-08 14:44 UTC)
Platform Info:
  System: Darwin (x86_64-apple-darwin13.4.0)
  CPU: Intel(R) Core(TM) i5-4258U CPU @ 2.40GHz
  WORD_SIZE: 64
  BLAS: libopenblas (USE64BITINT DYNAMIC_ARCH NO_AFFINITY Haswell)
  LAPACK: libopenblas
  LIBM: libopenlibm
  LLVM: libLLVM-3.3

[timholy]

@bjarthur noted that this can be triggered on 0.3, too, although the minimal testcase above is not sufficient to do it.
JuliaAttic/Color.jl#68