Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename MemoryError -> OutOfMemoryError #10503

Merged
merged 1 commit into from
Mar 15, 2015
Merged

Conversation

rened
Copy link
Member

@rened rened commented Mar 13, 2015

While it is clear to the core devs what a MemoryError is and this might feel like bike-sheddding, I believe that this will considerably improve the clarity of the error message for beginners.

This can turn the user experience of "I get these random internal memory errors. Julia is so not stable yet." into "I see, not enough memory. Will try with less data then."

Had to invest a couple of hours myself, trying to debug these elusive MemoryErrors which only occured on specific machines, while the root cause was so simple and my own fault.

@timholy
Copy link
Sponsor Member

timholy commented Mar 13, 2015

👍

1 similar comment
@aviks
Copy link
Member

aviks commented Mar 13, 2015

+1

@StefanKarpinski
Copy link
Sponsor Member

To be conservative, there should probably be an alias for the old name in base/deprecated.jl.

@rened
Copy link
Member Author

rened commented Mar 13, 2015

Good point, added MemoryError to deprecated.jl

@rened
Copy link
Member Author

rened commented Mar 13, 2015

The OSX build on travis had a timeout. Is there a better way to trigger a pull request rebuild than by pushing a dummy commit like I just did?

@nalimilan
Copy link
Member

I'm able to restart the build from the Travis webpage, but maybe you need rights to do that. If not, then you can always force-push the same commit, only updating the date: git commit --amend --date=now && git push rened +memoryerror. The commit you added fails the tests because of whitespaces...

@nalimilan
Copy link
Member

Oh, and you can remove that commit using git rebase -i HEAD~2, and then again a force-push.

@rened
Copy link
Member Author

rened commented Mar 14, 2015

thanks for the hint!

@IainNZ
Copy link
Member

IainNZ commented Mar 14, 2015

+1 to this

@StefanKarpinski
Copy link
Sponsor Member

Seems reasonable to me. @JeffBezanson, any opinion on the name change?

@JeffBezanson
Copy link
Sponsor Member

Fine by me.

ivarne added a commit that referenced this pull request Mar 15, 2015
rename MemoryError -> OutOfMemoryError
@ivarne ivarne merged commit def94c3 into JuliaLang:master Mar 15, 2015
@simonster simonster mentioned this pull request May 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants