correctly parse integer types in readdlm. fixes #9289 #10560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -87,7 +86,7 @@ function tryparse_internal(::Type{BigInt}, s::AbstractString, base::Int, raise:: | |||
| z = BigInt() | |||
| err = ccall((:__gmpz_set_str, :libgmp), | |||
| Int32, (Ptr{BigInt}, Ptr{UInt8}, Int32), | |||
| &z, SubString(s,i), base) | |||
| &z, bytestring(SubString(s,i,endpos)), base) | |||
There was a problem hiding this comment.
I believe ccall converts to ByteString automatically.
Used tryparse methods instead of float64_isvalid. If return array is of Any type, try parsing as Int, Bool and Float64 before falling back to substring.
JeffBezanson
added a commit
that referenced
this pull request
Mar 20, 2015
correctly parse integer types in readdlm. fixes #9289
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued from #9316
colvalmethod forIntegers.tryparse_internalmethods instead offloat64_isvalid.tryparse_internalto be able to parse a section of a string (avoids unnecessarySubStringcreation).Anytype, try parsing as the most common types (Int,BoolandFloat64) before falling back toSubString. The previous behavior was to tryFloat64only.There is no significant impact on performance with this change.