Make gc memory regions variable length. #13968
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2461,6 +2458,10 @@ void jl_gc_init(void) | |||
| last_long_collect_interval = default_collect_interval; | |||
| allocd_bytes = -default_collect_interval; | |||
|
|
|||
| char *max_pages_str = getenv("GC_MAX_PAGES"); | |||
There was a problem hiding this comment.
Make this JULIA_GC_MAX_PAGES. While at it, should probably change JL_GC_NO_GENERATIONAL to JULIA_GC_NO_GENERATIONAL
Try a bit harder to find a size the kernel will agree on when allocating. The max number of pages per region can be set with the env var JULIA_GC_MAX_PAGES. Should fix #10390.
carnaval
force-pushed
the
ob/mmapquota
branch
from
68855a5
to
ab611d3
Compare
| @@ -2461,6 +2458,10 @@ void jl_gc_init(void) | |||
| last_long_collect_interval = default_collect_interval; | |||
| allocd_bytes = -default_collect_interval; | |||
|
|
|||
| char *max_pages_str = getenv("JULIA_GC_MAX_PAGES"); | |||
There was a problem hiding this comment.
Should this maybe be specified in terms of total memory rather than pages? Internally, it's used to figure out a number of pages but it seems like this should be in the same units that ulimit -v is specified.
|
Any progress on this? I'm looking forward to having #10390 resolved. |
|
Replaced by #16385 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try a bit harder to find a size the kernel will agree on when allocating.
The max number of pages per region can be set with the env var JULIA_GC_MAX_PAGES.
Should fix #10390.