Clean up of gc debugging and page management code #16385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
||
| // A region is contiguous storage for up to REGION_PG_COUNT naturally aligned GC_PAGE_SZ pages | ||
| // It uses a very naive allocator (see jl_gc_alloc_page & jl_gc_free_page) | ||
| #if defined(_P64) && !defined(_COMPILER_MICROSOFT_) |
There was a problem hiding this comment.
I think we should be able to remove the msvc ifdef now if it's dynamically allocated
There was a problem hiding this comment.
Ah, yeah, forgot about this one....
Replace `PAGE_INDEX` with inline function.
|
I left the gcc workaround there. Unless someone can check on GCC 4.7 whether it is a problem. |
Also remove workaround for old GCC bug now that we require GCC 4.7
* Set region sizes based on `ulimit`. * Automatically shrink region size when allocation fails. Fix #10390
Clean up GC threading macros.
Remove the `memset(0xff)` when allocating a region.
|
lgtm, thanks. happy to see the current_heap macros go away too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rewrite of #13968 with a few related clean ups.
jl_thread_heap_tintojl_tls_states_t. Remove some infrastructures for accessing TLS variables on a different thread that exists beforejl_tls_states_t.I believe most of the changes should only affect slow path.