Fix errors: conrtib/build_{executable,sysimg}.jl #14176

KDr2 · 2015-11-28T11:28:12Z

fix few compile error
do NOT build both release file and debug file at once, build a release file by default, build a debug version by --debug option
add option --portable to build a portable executable file which can be run with LD_LIBRARY_PATH and JULIA_SYSIMG environment var set.

ViralBShah · 2015-11-28T14:31:26Z

tkelman · 2015-11-28T16:23:11Z

contrib/build_executable.jl

-    println("running: rm -rf $(tmpdir) $(sys.buildfile).o $(sys.buildfile0).o $(sys.buildfile0).ji")
-    map(f-> rm(f, recursive=true), [tmpdir, sys.buildfile*".o", sys.buildfile0*".o", sys.buildfile0*".ji"])
+    println("running: rm -rf $(tmpdir) $(sys.buildfile * ".o") $(sys.buildfile0 * ".o") $(sys.buildfile0 * ".ji")")
+    run(`rm -rf $(tmpdir) $(sys.buildfile * ".o") $(sys.buildfile0 * ".o") $(sys.buildfile0 * ".ji")`)


use the julia rm function, not the coreutils rm which is not going to be present on windows

done, thanks.

nalimilan · 2015-11-29T10:42:34Z

@ViralBShah Did you mean to CC somebody else? I've no particular knowledge about this file.

tkelman · 2015-11-29T12:11:30Z

@dhoegh has been pretty actively maintaining a version of this at https://github.com/dhoegh/BuildExecutable.jl - it might be worth actually migrating so there aren't 2 separate copies of this going forward

dhoegh · 2015-11-29T15:11:42Z

Yes I would deferentially appreciate the help at https://github.com/dhoegh/BuildExecutable.jl . I have already fixed some of the issues mentioned here. I support the idea of removing build_executable.jl from base as it is untested in base and the code is self-sustained. It is easier to fix bugs in the script, as BuildExecutable.jl do not need to follow base releases. At BuildExecutable.jl the code is tested on both Travis and Appveyor.

KDr2 · 2015-11-30T03:22:11Z

@dhoegh great work.
I would like to migrate the code to @dhoegh 's BuildExecutable.jl. But I should do this in my spare time, it may take more or less a week, I'll delete these two files from the julia base repo after that. This PR can be merged and I'll create a new one for the migration/deleting, Or just leave it here util the migration has been done. Is this a working plan? @tkelman @nalimilan @ViralBShah @dhoegh

dhoegh · 2015-11-30T19:51:38Z

My opinion is that build_sysimg.jl belongs in base and only build_executable.jl should be migrated and removed from base. I do only carry the build_sysimg.jl in the repository to fix build_executable.jl on 0.4, see #14018. When 0.4.2 is released I will bump the requirement to 0.4.2 and remove build_sysimg.jl from the repository.

tkelman · 2015-11-30T19:57:19Z

That makes sense to me. sysimg is needed if you want to make a change to base source and actually have it take effect, which can be a bit counterintuitive for newcomers.

KDr2 · 2015-12-04T02:25:34Z

I think this PR is ready to merge, I've migrated the change to @dhoegh's https://github.com/dhoegh/BuildExecutable.jl at dhoegh/BuildExecutable.jl#6 .

tkelman · 2015-12-04T02:27:03Z

Note the travis errors, make install needs to be updated for the removal of build_executable.jl. Do a git grep -n build_executable.jl to find if it's mentioned anywhere else.

KDr2 · 2015-12-04T13:18:04Z

Done, thanks. @tkelman

…ysimg

…ildExecutable.jl

tkelman · 2015-12-05T04:51:28Z

Travis failure was an unrelated repl test issue caused by fb48014. Thanks for the contribution!

Fix errors: conrtib/build_{executable,sysimg}.jl

dhoegh · 2015-12-08T20:42:25Z

Could the changes to build_sysimg.jl be backported to 0.4?

tkelman · 2015-12-08T20:46:24Z

I guess? The debug flag is a bit feature-y.

dhoegh · 2015-12-08T20:55:23Z

I see. If this got backported I would be able to get rid of the local copy of build_sysimg.jl I carry in https://github.com/dhoegh/BuildExecutable.jl which I would be nice.

tkelman · 2015-12-08T20:57:52Z

I thought the osx fix that did get backported was enough for that? What does having the debug flag fix?

dhoegh · 2015-12-08T21:20:04Z

In dhoegh/BuildExecutable.jl#6 @KDr2 states that

If I only have julia or julia-debug in my JULIA_HOME, it fails to build.
I do not know how @KDr2 is building/using julia but apparently in a way, where julia and julia-debug is not contained within JULIA_HOME.

tkelman · 2015-12-08T22:22:31Z

In a source build you might only have release but not debug present, or maybe the other way around.

I'm a bit skeptical of some of the changes over there with respect to JULIA_HOME, you should not be setting that environment variable or modifying it.

KDr2 · 2015-12-09T13:49:20Z

About the debug flag: Yeah, I usually build julia from source with make, or make julia-debug occasionally, and sometime I do make clean(all)?, so julia and julia-debug may not exist at the same time.
About unsetting/setting JULIA_HOME: I found jl_init_with_image we are using calls julia_init with JL_IMAGE_JULIA_HOME, when JULIA_HOME is set(usually to the bin directory under the julia installation), it will lookup the system image for our built executable under JULIA_HOME, not the directory where the executable placed. so I unset the JULIA_HOME before calling jl_init_with_image and reset it after the call. Maybe there's another better solution?

@tkelman @dhoegh

tkelman · 2015-12-09T13:59:13Z

Don't set JULIA_HOME in the first place?

KDr2 · 2015-12-09T15:38:46Z

Yes, don't set JULIA_HOME in the first place is the right way 😄 , and the c code will do nothing if we have no JULIA_HOME set.

But sometimes the JULIA_HOME is set

by accident(I mean not by user's intent, just forget to unset it, or set by a program which exec our executable...)
because the julia program which we are packaging is using ENV["JULIA_HOME"] for some purpose.

Or we can simply and clearly write this down into the document.

tkelman · 2015-12-09T16:01:23Z

That environment variable is significant to the julia runtime, so it shouldn't be used for arbitrary other purposes. That significance should be documented, or possibly removed if the original reasons for it are no longer applicable.

…ysimg (cherry picked from commit 61aba5a) ref #14176

tkelman reviewed Nov 28, 2015
View reviewed changes

KDr2 force-pushed the executable-builder branch from a3a1ef0 to fc7621b Compare November 29, 2015 12:06

KDr2 mentioned this pull request Dec 2, 2015

Separate debug/release build, and few bug fixes dhoegh/BuildExecutable.jl#6

Merged

KDr2 force-pushed the executable-builder branch from fc7621b to bb4efd0 Compare December 3, 2015 08:17

KDr2 added 3 commits December 4, 2015 23:07

add option '--debug', separate release/debug version while building s…

61aba5a

…ysimg

delete contrib/build_executable.jl, there's a well maintained pkg: Bu…

a2b53b3

…ildExecutable.jl

clear all things about contrib/build_executable.jl

1282a86

KDr2 force-pushed the executable-builder branch from 04d5dbc to 1282a86 Compare December 4, 2015 15:08

tkelman added a commit that referenced this pull request Dec 5, 2015

Merge pull request #14176 from KDr2/executable-builder

bac35d0

Fix errors: conrtib/build_{executable,sysimg}.jl

tkelman merged commit bac35d0 into JuliaLang:master Dec 5, 2015

KDr2 deleted the executable-builder branch December 5, 2015 12:16

dhoegh mentioned this pull request Dec 8, 2015

Register BuildExecutable: v0.0.1 JuliaLang/METADATA.jl#4183

Merged

tkelman added the backport pending 0.4 label Dec 8, 2015

tkelman pushed a commit that referenced this pull request Jan 9, 2016

add option '--debug', separate release/debug version while building s…

2c365af

…ysimg (cherry picked from commit 61aba5a) ref #14176

tkelman removed the backport pending 0.4 label Jan 13, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix errors: conrtib/build_{executable,sysimg}.jl #14176

Fix errors: conrtib/build_{executable,sysimg}.jl #14176

KDr2 commented Nov 28, 2015

ViralBShah commented Nov 28, 2015

tkelman Nov 28, 2015

KDr2 Nov 29, 2015

nalimilan commented Nov 29, 2015

tkelman commented Nov 29, 2015

dhoegh commented Nov 29, 2015

KDr2 commented Nov 30, 2015

dhoegh commented Nov 30, 2015

tkelman commented Nov 30, 2015

KDr2 commented Dec 4, 2015

tkelman commented Dec 4, 2015

KDr2 commented Dec 4, 2015

tkelman commented Dec 5, 2015

dhoegh commented Dec 8, 2015

tkelman commented Dec 8, 2015

dhoegh commented Dec 8, 2015

tkelman commented Dec 8, 2015

dhoegh commented Dec 8, 2015

tkelman commented Dec 8, 2015

KDr2 commented Dec 9, 2015

tkelman commented Dec 9, 2015

KDr2 commented Dec 9, 2015

tkelman commented Dec 9, 2015

Fix errors: conrtib/build_{executable,sysimg}.jl #14176

Fix errors: conrtib/build_{executable,sysimg}.jl #14176

Conversation

KDr2 commented Nov 28, 2015

ViralBShah commented Nov 28, 2015

tkelman Nov 28, 2015

Choose a reason for hiding this comment

KDr2 Nov 29, 2015

Choose a reason for hiding this comment

nalimilan commented Nov 29, 2015

tkelman commented Nov 29, 2015

dhoegh commented Nov 29, 2015

KDr2 commented Nov 30, 2015

dhoegh commented Nov 30, 2015

tkelman commented Nov 30, 2015

KDr2 commented Dec 4, 2015

tkelman commented Dec 4, 2015

KDr2 commented Dec 4, 2015

tkelman commented Dec 5, 2015

dhoegh commented Dec 8, 2015

tkelman commented Dec 8, 2015

dhoegh commented Dec 8, 2015

tkelman commented Dec 8, 2015

dhoegh commented Dec 8, 2015

tkelman commented Dec 8, 2015

KDr2 commented Dec 9, 2015

tkelman commented Dec 9, 2015

KDr2 commented Dec 9, 2015

tkelman commented Dec 9, 2015