correct shape for vec*mat error #14679 #14961
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The present definition will already give the error you ask for. It will just be thrown from the matmat method instead. julia> randn(2)*randn(2,2)
ERROR: DimensionMismatch("A has dimensions (2,1) but B has dimensions (2,2)")
in gemm_wrapper! at linalg/matmul.jl:312
in * at linalg/matmul.jl:89 |
|
This is from issue #14679. In your example, the dimension of A should be (2,), not (2,1). |
fwang88
force-pushed
the
master
branch
3 times, most recently
from
e1076f9
to
92ff0dd
Compare
…case In addition, macro except_str is moved from test/replutil.jl to base/test.jl for more usage in tests.
|
I added a test example. Since I'm quite new to all these, I'll appreciate a lot if any comments are provided. |
|
LGTM. Separate issue, but I wonder if using "A" and "B" in these error messages is maybe not the clearest... |
|
@tkelman Yes, I agree with you. But it seems the error message of any mismatched matrix multiplication uses "A" and "B", as used in function gemm_wrapper! |
|
Yeah, it should be consistent here for now, but there's an opportunity to make both clearer in the future. Thanks for the contribution! |
|
Fixed on current versions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the first dimension of a matrix is not 1, we should throw a dimension mismatch message for vec*mat.