-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Adds test_broken and test_skip macros #16105
Conversation
cb86223
to
dd7b571
Compare
This reverts commit 14dd1cf.
Other than the test report always displaying the count of how many there were, how is "skip" materially any different than commenting out a test? |
I think the current version |
How hard it would be implement skipping of testsets with appropriate reporting? |
see #17038 |
thanks, @tkelman |
test_broken
andtest_skip
can be used to designate tests that should pass but don't. In an attempt to be noticed by testers they produce aBroken
result.test_skip
will simply skip over testing, andtest_broken
will raise an error to alert the user if the test unexpectedly succeeds.This pull request is a continuation of #15832.