fix #17572, error during inference due to <: on non-Type
#17621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| catch me | ||
| # cannot convert to non-type `0` | ||
| @test isa(me,MethodError) && me.f === convert | ||
| end |
There was a problem hiding this comment.
this test doesn't fail for me on master. I think you need to call code_typed directly and show that there is no error being thrown.
also, since it's not testing core, it should go in test/inference.jl (so you don't get rebase conflicts :)
JeffBezanson
force-pushed
the
jb/fix17572
branch
from
a88060e
to
0eb9428
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.