Fix build for LLVM 4.0 after commit r276654 #17665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In LLVM commit r276654 the signature of Target::createMCAsmBackend() changed and now requires a fourth parameter of type MCTargetOptions. For our purposes it is sufficient to pass a default constructed MCTargetOptions instance since this seems to preserve the original behaviour.
MatthiasJReisinger
force-pushed
the
mjr/llvm4
branch
from
6d78d5c
to
27a4a56
Compare
|
Travis lin64 is #17662 |
kshyatt
added
the
domain:building
|
LGTM after CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit r276654 in LLVM the signature of
Target::createMCAsmBackend()changed and now requires a fourth parameter of typeMCTargetOptions. For our purposes it is sufficient to pass a default constructedMCTargetOptionsinstance since this seems to preserve the original behaviour.