New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build for LLVM 4.0 after commit r276654 #17665

Merged
merged 1 commit into from Jul 29, 2016

Conversation

4 participants
@MatthiasJReisinger
Contributor

MatthiasJReisinger commented Jul 28, 2016

In commit r276654 in LLVM the signature of Target::createMCAsmBackend() changed and now requires a fourth parameter of type MCTargetOptions. For our purposes it is sufficient to pass a default constructed MCTargetOptions instance since this seems to preserve the original behaviour.

Fix build for LLVM 4.0 after commit r276654
In LLVM commit r276654 the signature of Target::createMCAsmBackend() changed and now requires a fourth parameter of type MCTargetOptions. For our purposes it is sufficient to pass a default constructed MCTargetOptions instance since this seems to preserve the original behaviour.

@MatthiasJReisinger MatthiasJReisinger force-pushed the MatthiasJReisinger:mjr/llvm4 branch from 6d78d5c to 27a4a56 Jul 28, 2016

@yuyichao

This comment has been minimized.

Member

yuyichao commented Jul 28, 2016

Travis lin64 is #17662

@kshyatt kshyatt added the build label Jul 28, 2016

@yuyichao yuyichao closed this Jul 28, 2016

@yuyichao yuyichao reopened this Jul 28, 2016

@Keno

This comment has been minimized.

Member

Keno commented Jul 29, 2016

LGTM after CI.

@yuyichao yuyichao merged commit 2b98dda into JuliaLang:master Jul 29, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MatthiasJReisinger MatthiasJReisinger deleted the MatthiasJReisinger:mjr/llvm4 branch Jul 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment