Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reattach filter's docstring #19057

Merged
merged 1 commit into from
Oct 26, 2016
Merged

Reattach filter's docstring #19057

merged 1 commit into from
Oct 26, 2016

Conversation

Sacha0
Copy link
Member

@Sacha0 Sacha0 commented Oct 21, 2016

#18839 moved the docstring-bearing filter method into module Iterators. Module Iterators does not import filter from Base, so filter's docstring no longer attaches to Base.filter:

julia> VERSION
v"0.6.0-dev.1054"

help?> filter
search: filter filter! PollingFileWatcher fieldtype

  No documentation found.

  Base.filter is a Function.

  #7 methods for generic function "filter":
  filter(f, a::Array{T<:Any,1}) at array.jl:1656
  filter(f, Bs::BitArray) at bitarray.jl:2014
  filter(f, As::AbstractArray) at array.jl:1641
  filter(f, d::Associative) at associative.jl:211
  filter(f, s::Set) at set.jl:171
  filter(f, s::AbstractString) at strings/basic.jl:449
  filter(flt, itr) at deprecated.jl:49

This pull request attaches filter's docstring to filter's AbstractArray fallback in base/array.jl. Best!

…ather than an Iterators.filter method not pulled into Base).
@stevengj stevengj added the docs This change adds or pertains to documentation label Oct 21, 2016
@tkelman tkelman merged commit dee3c54 into JuliaLang:master Oct 26, 2016
@Sacha0 Sacha0 deleted the fixfilterdocs branch October 26, 2016 18:23
fcard pushed a commit to fcard/julia that referenced this pull request Feb 28, 2017
…ather than an Iterators.filter method not pulled into Base). (JuliaLang#19057)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change adds or pertains to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants