improve error message for unescape_string #21255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyatt
added
the
domain:error handling
kshyatt
approved these changes
Apr 2, 2017
|
This is fine, but in the future it's nice to post an example of what the error looks like after your change. |
|
Sure thing, will do. Thanks for merging! |
| @@ -299,7 +299,8 @@ function unescape_string(io, s::AbstractString) | |||
| i = j | |||
| end | |||
| if k == 1 | |||
| throw(ArgumentError("\\x used with no following hex digits in $(repr(s))")) | |||
| throw(ArgumentError("invalid $(m == 2 ? "hex (\\x)" : | |||
| "unicode (\\u)") escape sequence used in $(repr(s))")) | |||
There was a problem hiding this comment.
If we're going to be this specific, why not go all the way and differentiate \u and \U correctly as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
just looks confusing.