Issue #20062: make Random.reserve type-stable #22446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(CI failures were timeouts except AV i686, which looks like an unrelated |
tkelman
reviewed
Jun 20, 2017
test/random.jl
Outdated
| @test !Base.Random.mt_empty(r); @inferred Base.Random.reserve_1(r) | ||
|
|
||
| rand(r) | ||
| @test 0 < Base.Random.mt_avail(r) < Base.Random.MTCacheLength; @inferred Base.Random.reserve(r, Base.Random.mt_avail(r)) |
There was a problem hiding this comment.
these seem like two separate tests, and go over the line length recommendation
There was a problem hiding this comment.
I was probably being overly-cautious with these tests, trying to test inferred return type on different conditions of mt_avail. Probably sufficient to test once only. Will update to simplify.
rfourquet
added
compiler:inference
Sacha0
approved these changes
Jun 21, 2017
quinnj
pushed a commit
that referenced
this pull request
Jun 24, 2017
DrTodd13
pushed a commit
to IntelLabs/julia
that referenced
this pull request
Jun 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #20062
Not a performance issue, but does pollute
@code_warntypefor functions that includerand().Also thought that returning
nothingbetter documents that return value is not used.