Bugfix for zero matrix in A_ldiv_B! for QRPivoted #22831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasnoack
approved these changes
Jul 16, 2017
fredrikekre
reviewed
Jul 16, 2017
test/linalg/qr.jl
Outdated
| A = zeros(1, 2) | ||
| B = zeros(1, 1) | ||
| @test A \ B == zeros(2, 1) | ||
| @test qrfact(A, Val{true}) \ B == zeros(2, 1) |
Sacha0
approved these changes
Jul 16, 2017
jeffwong
pushed a commit
to jeffwong/julia
that referenced
this pull request
Jul 24, 2017
* Bugfix for zero matrix in A_ldiv_B! for QRPivoted. * Address review comments.
ararslan
pushed a commit
that referenced
this pull request
Sep 11, 2017
ararslan
pushed a commit
that referenced
this pull request
Sep 13, 2017
* Bugfix for zero matrix in A_ldiv_B! for QRPivoted. * Address review comments. (cherry picked from commit bf47fd9)
vtjnash
pushed a commit
that referenced
this pull request
Sep 14, 2017
* Bugfix for zero matrix in A_ldiv_B! for QRPivoted. * Address review comments. (cherry picked from commit bf47fd9)
ararslan
pushed a commit
that referenced
this pull request
Sep 15, 2017
* Bugfix for zero matrix in A_ldiv_B! for QRPivoted. * Address review comments. (cherry picked from commit bf47fd9)
ararslan
pushed a commit
that referenced
this pull request
Sep 16, 2017
* Bugfix for zero matrix in A_ldiv_B! for QRPivoted. * Address review comments. (cherry picked from commit bf47fd9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this fixes #22810 but needs review by someone who is familiar with this code.