Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add '-Wl,--export-all-symbols' flag on Windows #24248

Conversation

lucatrv
Copy link
Contributor

@lucatrv lucatrv commented Oct 20, 2017

This is a temporary hack, which should not be necessary in future, see issue #24010

@lucatrv lucatrv force-pushed the add_export-all-symbol_flag_on_windows branch from 52611cf to aec4f87 Compare October 21, 2017 10:52
@lucatrv lucatrv changed the title Add -Wl,--export-all-symbols flag on Windows Add '-Wl,--export-all-symbols' flag on Windows Oct 21, 2017
@vtjnash
Copy link
Sponsor Member

vtjnash commented Oct 21, 2017

This script should not be setting linker flags (juliac.jl / build_sysimg.jl / etc. should add their own). I'm not really sure how/why -Wl,--export-dynamic ended up getting set here either. It looks like this whole if block is supposed to be deleted.

@ViralBShah
Copy link
Member

Let's close this if it is not the right thing here. juliac.jl can do its own thing for now.

@lucatrv
Copy link
Contributor Author

lucatrv commented Oct 22, 2017

Yes sure I will close this, but I have a question: will all the linker flags be removed from julia-config.jl? (only -Wl,--export-dynamic or also all the others?). I ask because consequently juliac.jl would need to be updated with all flags removed from julia-config.jl.
Thanks

@kshyatt kshyatt added the system:windows Affects only Windows label Oct 23, 2017
@lucatrv lucatrv closed this Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system:windows Affects only Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants