Simplify A[1, end] lowering with lastindex(A, n) #25763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements a new method of `lastindex` to specify a given dimension, and then uses that new method in the lowering of `end` within multi-dimensional indices. Previously, this would have lowered directly to `last(axes(A, d))` for `end` in position `d`. Given that `axes` (and multidimensional indexing generally) are array-centric concepts, I have only implemented this for `::AbstractArray`, with a deprecation for all other types suggesting implemention if sensible. I have similarly defined `firstindex(A, d)` - it will be available for its syntax transformation in the future.
mbauman
added
compiler:lowering
Keno
approved these changes
Jan 26, 2018
src/julia-syntax.scm
Outdated
| @@ -90,16 +90,16 @@ | |||
| ;; the array `a` in the `n`th index. | |||
| ;; `tuples` are a list of the splatted arguments that precede index `n` | |||
| ;; `last` = is this last index? | |||
| ;; returns a call to lastindex(a) or last(axes(a,n)) | |||
| ;; returns a call to lastindex(a) or lastindex(a,n)) | |||
Keno
added a commit
that referenced
this pull request
Jan 29, 2018
This attempts to address some of the performance regressions observed with the Stateful iterator #25763. It gets most of the way there, but unfortunately still ends up allocating the `Stateful` iterator object rather than propagating through the fields. Getting the rest of the way there will require some compiler tweaks.
mbauman
added a commit
that referenced
this pull request
Feb 8, 2018
I missed this change in #25763.
JeffBezanson
pushed a commit
that referenced
this pull request
Feb 9, 2018
I missed this change in #25763.
|
It would be nice to document the new methods. Also |
|
Just a heads up this is missing a deprecation for the rename of |
|
This does implement a deprecation. Are you referring to a deprecation of |
|
I see, that makes sense as to why I was not getting the deprecation. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a new method of
lastindexto specify a given dimension, and then uses that new method in the lowering ofendwithin multi-dimensional indices. Previously, this would have lowered directly tolast(axes(A, d))forendin positiond. Given thataxes(and multidimensional indexing generally) are array-centric concepts, I have only implemented this for::AbstractArray, with a deprecation for all other types suggesting implemention if sensible. I have similarly definedfirstindex(A, d)(albeit without the deprecation). It will be available for its syntax transformation in the future.